missing hook should fail the build
Bug #1043701 reported by
Martin Mrazik
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| PBuilderJenkins |
Fix Released
|
High
|
Sergio Schvezov | ||
Bug Description
I would prefer to fail the build if a hook is missing instead of issuing a warning:
WARNING:
Missing hook is IMHO fairly critical as your build might be doing something else than you expect so being strict makes sense to me.
Related branches
lp:~sergiusens/pbuilderjenkins/missing_hook
- jenkins (community): Needs Fixing (continuous-integration)
- Sergio Schvezov: Approve
- Martin Mrazik (community): Approve
-
Diff: 123 lines (+83/-6)3 files modifieddebian/changelog (+8/-2)
pbuilderjenkins/pbuilderjenkins.py (+9/-4)
tests/test_hooks_setup.py (+66/-0)
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | #1 |
| Changed in pbuilderjenkins: | |
| importance: | Undecided → High |
| assignee: | nobody → Sergio Schvezov (sergiusens) |
| status: | New → Confirmed |
| Changed in pbuilderjenkins: | |
| status: | Confirmed → In Progress |
| Changed in pbuilderjenkins: | |
| status: | In Progress → Fix Committed |
| Changed in pbuilderjenkins: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
agreed, this was there to enable de proof of concept until we were bootstrapped.