When converting audio only, file extension should be .oga or .mp3

Bug #1043124 reported by Marco Lechner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firefogg
New
Undecided
Unassigned

Bug Description

Hi when converting audiofiles or videos with options.novideo = true the file extension of the resulting file should be .oga (or may be selectable .mp3). This should be easily to implement:
in make.js:
    $('#encodeButton').click(function() {
        var options = serializeOptions(),
            started = new Date();
        if(options.novideo == 'true') {
            ogg.setFormat('oga')
            //TODO may be add options.audioFormat as condition and make mp3 available
        } else {
            if(options.videoCodec == 'vp8') {
                ogg.setFormat('webm');
            } else {
                ogg.setFormat('ogg');
            }
        }

the Firefogg.js (class) in the Plugins components dir has to handle this:
  saveVideoAs: function() {
    const nsIFilePicker = Ci.nsIFilePicker;
    var fp = Cc["@mozilla.org/filepicker;1"].createInstance(nsIFilePicker);
    fp.init(this._window, "Save video as...", nsIFilePicker.modeSave);
    fp.appendFilters(nsIFilePicker.filterAll);

    var path = this._inputFile;
    if(path) {
      if (this._options.novideo == true){
          var extension = '.oga';
          if(this._format == 'webm') {
              extension = '.webma';
          }
      } else {
          var extension = '.ogv';
          if(this._format == 'webm') {
              extension = '.webm';
          }
      }

Revision history for this message
Marco Lechner (dr-marco) wrote :

btw: it's firefogg 3.0.8

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.