can't update volume and snapshot display_name

Bug #1042904 reported by clayg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
clayg
OpenStack Compute (nova)
Invalid
Medium
clayg

Bug Description

the python-novaclient supports a top level command "rename" - volumes needs some of that too!

$ curl -s http://10.127.0.28:8776/v1/83833af048414960ad5e09f59b537b59/volumes/110925a5-664c-4a1b-a3cd-aca0818f359e -H 'x-auth-token: c426c362275549cd938d41d6736d3219' -H 'content-type: application/json' -XPUT -d '{"volume": {"display_name": "new-name"}}' | python -m json.tool
{
    "itemNotFound": {
        "code": 404,
        "message": "The resource could not be found."
    }
}

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12067

Changed in cinder:
status: New → In Progress
Changed in cinder:
milestone: none → folsom-rc1
Changed in cinder:
milestone: folsom-rc1 → none
clayg (clay-gerrard)
Changed in nova:
assignee: nobody → clayg (clay-gerrard)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12816

Mark McLoughlin (markmc)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/12067
Committed: http://github.com/openstack/cinder/commit/04ca527aa394376b20e1fc09b1cdd1ca8a0a105a
Submitter: Jenkins
Branch: master

commit 04ca527aa394376b20e1fc09b1cdd1ca8a0a105a
Author: Clay Gerrard <email address hidden>
Date: Mon Aug 27 21:38:25 2012 +0000

    Add update to volume and snapshot controllers

    Add update method to api.openstack.volume.volumes and snapshots
    controllers. Url mapping automatically routes a PUT on the resource to
    the update method. Implementation closely matches updates to server
    resource for the openstack compute api.

    e.g.

    curl http://localhost:8776/v1/${PROJECT_ID}/volumes/${VOLUME_ID} \
        -H 'x-auth-token: ${ADMIN_AUTH_TOKEN}' \
        -H 'content-type: application/json' \
        -XPUT -d '{"volume": {"display_name": "new-name"}}'

    Add volume.api.API.update_snapshot method to avoid making db calls
    directly from the SnapshotsController.

    Add tests for new methods.

    Update return value of test_volume.VolumeTestCase._create_snapshot
    to return the whole model like _create_volume

    fixes lp bug #1042904

    Change-Id: I887178f9b7834cc7afd54bba8fb902b630faf8c0

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-1 → 2013.1
Revision history for this message
Sean Dague (sdague) wrote :

Fixed in cinder, I think that's the only place it needs fixing

Changed in nova:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.