Mark Serial Number required
Bug #1041282 reported by
Chris Johnston
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| QA Lab Manager |
Fix Released
|
Low
|
Chris Johnston | ||
Bug Description
Some devices don't have IP addresses or MAC addresses, so these items shouldn't be required
Related branches
lp:~cjohnston/qalm/fixes-1041282
- Chris Johnston: Pending requested
-
Diff: 68 lines (+51/-1)2 files modifiedlab_manager/hardware/migrations/0003_make_sn_required.py (+50/-0)
lab_manager/hardware/models/hardwaremodel.py (+1/-1)
Revision history for this message
| Larry E Works (larry-e-works) wrote | #1 |
| Changed in lab-manager: | |
| status: | New → Confirmed |
| status: | Confirmed → Triaged |
| status: | Triaged → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Chris Johnston (chrisjohnston) |
| summary: |
- Not all fields should be required + Mark Serial Number required |
| Changed in lab-manager: | |
| status: | In Progress → Fix Committed |
| Changed in lab-manager: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Requiring a MAC address and entering N/A for it is fine from my perspective. Making the IP address required, not so much. There are several reasons for this: Some devices, specifically the KVM console (not the KVM switch), won't have a network interface so there is no possible way it would have an IP. Other devices we may want to leave configured for DHCP so we wouldn't want to enter an IP. Either way, the MAC being mandatory field is fine since we can enter N/A; you just won't be able to use the MAC to define the device.
Fields that I think should be mandatory:
- Lab
- Device Name (the name we assign to the device)
- Make/Manufacturer
- Model
- Serial Number
- Type of device
- Firmware Version (N/A can be used)
- MAC address (N/A can be used)