PowerVM compute driver still using older spawn signature

Bug #1040770 reported by David Peraza
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Tiago Mello

Bug Description

spawn in virt.driver:

def spawn(self, context, instance, image_meta, injected_files,
              admin_password, network_info=None, block_device_info=None):

notice 5 params required here

spwan implementation in virt.powervm.driver:

def spawn(self, context, instance, image_meta,
              network_info=None, block_device_info=None):
notice 3 params required here

I do get a signature mismatch trying to launch powervm instance. It gets fixed if we just update signature, since param names are still the same and new params are not currently used

Tags: powervm
Dan Prince (dan-prince)
Changed in nova:
status: New → Triaged
importance: Undecided → Medium
milestone: none → folsom-rc1
Tiago Mello (timello)
Changed in nova:
assignee: nobody → Tiago Rodrigues de Mello (tmello)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12065

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/12065
Committed: http://github.com/openstack/nova/commit/b3d2322f0deba47b42318b9b04b26ac22ae0a5ff
Submitter: Jenkins
Branch: master

commit b3d2322f0deba47b42318b9b04b26ac22ae0a5ff
Author: Tiago Mello <email address hidden>
Date: Tue Aug 28 14:51:45 2012 -0400

    Fixes spawn method signature for PowerVM driver.

    ComputeDriver has now 2 new required arguments which are:
    injected_files and admin_password. This patch adds the
    arguments in the PowerVMDriver spawn signature.

    Fixes bug 1040770

    Change-Id: I0a45fa45c942f2d0381c5a7310d386ae655073fe

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.