pmp-check-mysql-replication-delay doesn't alert if second behing master is NULL
Bug #1040528 reported by
Miguel Angel Nieto
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Monitoring Plugins |
Fix Released
|
High
|
Brian Fraser |
Bug Description
In a master-slave server, when the slave is stopped (STOP SLAVE) the check script doesn't work.
# ./pmp-check-
[: 129: Illegal number: NULL
[: 129: Illegal number: NULL
OK NULL seconds of replication delay
- It tries to compare a string with an integer
- It shows OK when the lag is NULL
Related branches
lp:~fraserbn/percona-monitoring-plugins/fix-1040528-pmp-mysql-delay-if-seconds-behind-master-is-zero
- Daniel Nichter: Approve
- Brian Fraser (community): Approve
-
Diff: 74 lines (+50/-1)3 files modifiednagios/bin/pmp-check-mysql-replication-delay (+3/-1)
t/nagios/pmp-check-mysql-replication-delay/check-functions.sh (+8/-0)
t/nagios/pmp-check-mysql-replication-delay/samples/show-slave-status-002.txt (+39/-0)
lp:~roman-vynar/percona-monitoring-plugins/release-1.0.2
- Roman Vynar: Approve
- Ryan Huddleston: Pending requested
-
Diff: 3540 lines (+2337/-516)33 files modifiedChangelog (+14/-0)
VERSION (+1/-1)
build/build.sh (+91/-0)
build/deb/percona-cacti-templates/control (+15/-0)
build/deb/percona-cacti-templates/copyright (+24/-0)
build/deb/percona-cacti-templates/files (+14/-0)
build/deb/percona-cacti-templates/postinst (+4/-0)
build/deb/percona-nagios-plugins/control (+14/-0)
build/deb/percona-nagios-plugins/copyright (+24/-0)
build/deb/percona-nagios-plugins/files (+7/-0)
build/deb/percona-nagios-plugins/postinst (+3/-0)
build/rpm/percona-cacti-templates.spec (+54/-0)
build/rpm/percona-nagios-plugins.spec (+42/-0)
cacti/definitions/gnu_linux.def (+28/-1)
cacti/scripts/ss_get_by_ssh.php (+4/-4)
dev-docs/making-releases.rst (+13/-0)
docs/cacti/creating-graphs.rst (+4/-4)
docs/cacti/developer-documentation.rst (+1/-0)
docs/cacti/installing-templates.rst (+3/-0)
docs/cacti/mysql-templates.rst (+3/-1)
docs/cacti/ssh-based-templates.rst (+1/-0)
docs/cacti/unix-templates.rst (+36/-12)
docs/config/percona-theme/layout.html (+77/-205)
docs/config/percona-theme/static/default.css_t (+6/-42)
docs/config/percona-theme/static/percona.com.css (+1783/-204)
make.sh (+25/-10)
nagios/bin/pmp-check-mysql-file-privs (+1/-1)
nagios/bin/pmp-check-mysql-status (+8/-3)
nagios/bin/pmp-check-pt-table-checksum (+3/-7)
nagios/bin/pmp-check-unix-memory (+20/-15)
t/cacti/get_by_ssh.php (+5/-5)
t/cacti/misc_functions_1.php (+1/-1)
t/nagios/pmp-check-mysql-status/check-functions.sh (+8/-0)
Changed in percona-monitoring-plugins: | |
assignee: | nobody → Brian Fraser (fraserbn) |
status: | New → In Progress |
importance: | Undecided → High |
Changed in percona-monitoring-plugins: | |
status: | In Progress → Fix Committed |
Changed in percona-monitoring-plugins: | |
milestone: | none → 1.0.2 |
Changed in percona-monitoring-plugins: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.