Two-player swaps don't work with full teams in warmup mode

[Yann Kaiser]

To reproduce:

1. Fill two teams with players
2. While in warmup mode, have a player from each team try to swap
3. The second player to set their teamwish will be moved to the other team, then back. This repeats until the player changes their team wish.

[Matias Pino (pnoexz)]

I couldnt figure this one out by myself, but i found code for swapping in eTeam.cpp:1328.

[Matias Pino (pnoexz)]

I tried duplicating this using a dedicated server and 3 (lets call them alpha, beta, gamma, respectively) clients but wasnt able to. Using ladle settings, changed max players per team to 1, changed teams from alpha, but when i tried to do it from beta, it automatically switched teams mid round, finishing it. At this time, alpha switches the team, thus finishing the swap correctly. By the time i managed to stop beta from auto joining the team mid round and get both clients to watch to switch, beta's next team was reset to the current team (team red ;)), no messages about switching twice, though it does look like that happens.

Gamma was only used to see if teams were really full, and they were. Nothing relevant on STDOUT, no STDERR.

[Yann Kaiser (epsy)]

Couldn't reproduce :-( Could use speeding up swapping by doing it midround though.