glance image service not converting exceptions properly

[Chris Behrens]

glance image service is not checking all exceptions properly. HTTPNotFound can be raised from glanceclient, and that slips through...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/11734

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/11734
Committed: http://github.com/openstack/nova/commit/3c73cbf550ebb3d3b0869f4ebd3870530c92f721
Submitter: Jenkins
Branch: master

commit 3c73cbf550ebb3d3b0869f4ebd3870530c92f721
Author: Chris Behrens <email address hidden>
Date: Tue Aug 21 18:28:59 2012 +0000

    Make glance image service check base exception classes

    Fixes bug 1039675

    glanceclient can raise HTTPNotFound (as well as NotFound) it appears,
    but glance image service is only converting NotFound ->
    InstanceNotFound. Same applies to 'Forbidden' and other exceptions.

    This patch converts 'exc_type is NotFound'-like checks to use
    'isinstance' instead, which will cover HTTPNotFound, etc.

    Change-Id: I0982875e667121cee3da3cfe0124499cad484fa6