bug.transitionToInformationType does not respect BugSharingPolicy

[Curtis Hovey]

This bug extends the work of bug 1036185. The default bug creation rule are enforced, but the transition rules are not enforced.

For example I set bugs are proprietary only.
    https://qastaging.launchpad.net/lp-dev-utils/+sharing

I reported
    https://bugs.qastaging.launchpad.net/lp-dev-utils/+bug/939548

which was proprietary when It was created. The UI would not let me choose another type. I expected an error to be raised when I ran this API function:
def test_bug_sharing_policy():
    lp = Launchpad.login_with(
        'testing', service_root='https://api.qastaging.launchpad.net',
        version='devel')
    bug = lp.bugs['939548']
    bug.transitionToInformationType(
        information_type="Public")

But there was no error, when I refreshed the page, the bug was public, even though the policy says I will not permit it.

This is roughly what I think is missing.

class BugInformationTypeNotPermitted:
    """The information type is forbidden by the project's BugSharingPolicy."""

Bug.transitionToInformationType()
        if information_type not in self.getAllowedBugInformationTypes():
            raise BugSharingPolicyError()

[William Grant (wgrant)]

Right, this is what I was working on yesterday, but there's a fair bit of test fallout.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r15887 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15887>.