improper embedding of svn_info_t/svn_client_info2_t

Bug #1039133 reported by Samuel Bronson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
subvertpy
Triaged
Medium
Unassigned

Bug Description

The documentation for svn_info_t/svn_client_info2_t say that users should not allocate objects of these types, since fields might be added at the end (and they have been!), but I see this code in client.c:

typedef struct {
    PyObject_HEAD
#if ONLY_SINCE_SVN(1, 7)
    svn_wc_info_t info;
#else
    svn_info_t info;
#endif
    apr_pool_t *pool;
} WCInfoObject;

typedef struct {
    PyObject_HEAD
#if ONLY_SINCE_SVN(1, 7)
    svn_client_info2_t info;
#else
    svn_info_t info;
#endif
    WCInfoObject *wc_info;
    apr_pool_t *pool;
} InfoObject;

It would probably be a good idea to fix that?

Jelmer Vernooij (jelmer)
Changed in subvertpy:
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.