lesson dialog problems

Bug #1037189 reported by Marten de Vries
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenTeacher
Fix Released
High
Cas Widdershoven

Bug Description

Checking if tab switching (between enter, teach, results) is allowed for lessons is handled by the central lesson dialogs module. This module/how it is used everywhere contains two bugs:

1) the tabChanged events are handled in the module class. If you have two tabs open with files of the same type (e.g. two words tabs), the module can't see the difference. This is true because the enterWidget and teachWidget that are passed aren't gotten from the lesson object, but saved in the modules namespace (self.enterWidget, etc.).
Fixed from rev. 264 onwards.

2) the module itself does check for switching from the teachWidget (while inLesson) to the enter widget, but not to the results widget. Fixing this is complicated by the fact that the results widget is strictly spoken optional (if the modules showing the results aren't enabled, the lessons still work without the tab.)

Changed in openteacher:
status: Confirmed → Triaged
description: updated
Revision history for this message
Marten de Vries (marten-de-vries) wrote :

Number 2 isn't really a bug.
-> Fixed.

Changed in openteacher:
assignee: nobody → Cas Widdershoven (caswiddershoven)
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.