Multi-file download

[Paul Everitt]

Summary: Users would like to select a number of files and download them at once

User Story

Nat walks up to a KARL folder, selects 3 files and a subfolder, clicks Download. After answering a confirmation, they are asked to save a ZIP file which contains the 3 files, the sudirectory, and the items in the subdirectory.

Specification

- Button is disabled until selection, like the "Move To" and "Delete" buttons
- If the user selects 5 files whose bytes add up to more than 20 Mb, when they click Download, display a popup telling them it is too big
- Have to do a zip file, browsers can't do multifile download
- In UX1 we do batching, which means they can only select files to download from one batch.
- In UX2 we do infinite scrolling, so we can do selection anywhere in a folder
- The confirmation popup should tell them how many items they selected. Like "Are you sure you want to download these 7 items in a ZIP file?"
- If a subfolder is selected, make a subdirectory in the ZIP file for the folder and stick all the items in the KARL subfolder into that subdirectory

Question to Carlos

- How much extra to do it for both ux1/ux2? SlickGrid has a very different selection model.

[Paul Everitt (paul-agendaless)]

Nat can confirm that I got this right. Once Carlos answers the question at the bottom, we can green light it.

[Carlos de la Guardia (cguardia)]

I don't think the overhead for doing both would be more than 10-15%.

[Paul Everitt (paul-agendaless)]

Ok, sold. Let's make a branch and get started. We'll do UX1 first.

--Paul

On Aug 15, 2012, at 5:14 AM, Carlos de la Guardia wrote:

> I don't think the overhead for doing both would be more than 10-15%.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1036870
>
> Title:
> Multi-file download
>
> Status in KARL3:
> New
>
> Bug description:
> Summary: Users would like to select a number of files and download
> them at once
>
> User Story
>
> Nat walks up to a KARL folder, selects 3 files and a subfolder, clicks
> Download. After answering a confirmation, they are asked to save a ZIP
> file which contains the 3 files, the sudirectory, and the items in the
> subdirectory.
>
> Specification
>
> - Button is disabled until selection, like the "Move To" and "Delete" buttons
> - If the user selects 5 files whose bytes add up to more than 20 Mb, when they click Download, display a popup telling them it is too big
> - Have to do a zip file, browsers can't do multifile download
> - In UX1 we do batching, which means they can only select files to download from one batch.
> - In UX2 we do infinite scrolling, so we can do selection anywhere in a folder
> - The confirmation popup should tell them how many items they selected. Like "Are you sure you want to download these 7 items in a ZIP file?"
> - If a subfolder is selected, make a subdirectory in the ZIP file for the folder and stick all the items in the KARL subfolder into that subdirectory
>
> Question to Carlos
>
> - How much extra to do it for both ux1/ux2? SlickGrid has a very
> different selection model.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036870/+subscriptions

[Nat Katin-Borland (nborland)]

Sounds good to me. Quick clarification: what's the significance of choosing 5 files that add up to over 20 MB? Wouldn't it be any number of files adding up to more than 20 MB? Maybe I'm missing something...

[Paul Everitt (paul-agendaless)]

To reply to Nat...I meant that the sum of all sizes shouldn't add up to 20 Mb.

[Carlos de la Guardia (cguardia)]

Deployed ux1 test branch to cguardia-multi-download.

[Carlos de la Guardia (cguardia)]

Deployed ux2 version to same branch.

[Paul Everitt (paul-agendaless)]

Good job Carlos, everything looks pretty good. One worrisome part. My unzip client said this:

$ unzip ~/Downloads/default_files.zip
Archive: /Users/paul/Downloads/default_files.zip
warning: stripped absolute path spec from /2012wellnesspool.pdf
  inflating: 2012wellnesspool.pdf
warning: stripped absolute path spec from /2012girlsrules.pdf
  inflating: 2012girlsrules.pdf

Those warnings make me think that the files are put into the ZIP file in the wrong way. Any comments or thoughts?

--Paul

On Aug 22, 2012, at 10:37 PM, Carlos de la Guardia wrote:

> Deployed ux2 version to same branch.
>
> ** Changed in: karl3
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1036870
>
> Title:
> Multi-file download
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> Summary: Users would like to select a number of files and download
> them at once
>
> User Story
>
> Nat walks up to a KARL folder, selects 3 files and a subfolder, clicks
> Download. After answering a confirmation, they are asked to save a ZIP
> file which contains the 3 files, the sudirectory, and the items in the
> subdirectory.
>
> Specification
>
> - Button is disabled until selection, like the "Move To" and "Delete" buttons
> - If the user selects 5 files whose bytes add up to more than 20 Mb, when they click Download, display a popup telling them it is too big
> - Have to do a zip file, browsers can't do multifile download
> - In UX1 we do batching, which means they can only select files to download from one batch.
> - In UX2 we do infinite scrolling, so we can do selection anywhere in a folder
> - The confirmation popup should tell them how many items they selected. Like "Are you sure you want to download these 7 items in a ZIP file?"
> - If a subfolder is selected, make a subdirectory in the ZIP file for the folder and stick all the items in the KARL subfolder into that subdirectory
>
> Question to Carlos
>
> - How much extra to do it for both ux1/ux2? SlickGrid has a very
> different selection model.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036870/+subscriptions

[JimPGlenn (jpglenn09)]

I tested this on IE8 and got a blocked file when trying to extract from zip file see screen capture. The help screen says to force
the file by changing properties to unblock, when I go to properties I do not get any status reported at all.

[Paul Everitt (paul-agendaless)]

Hmm, that's one that I'm not sure I know much about. That's an issue with Windows and ZIP files, which isn't really part of KARL.

--Paul

On Aug 23, 2012, at 9:56 AM, JimPGlenn wrote:

> I tested this on IE8 and got a blocked file when trying to extract from zip file see screen capture. The help screen says to force
> the file by changing properties to unblock, when I go to properties I do not get any status reported at all.
>
> ** Attachment added: "blocked-2012-08-23.png"
> https://bugs.launchpad.net/karl3/+bug/1036870/+attachment/3273339/+files/blocked-2012-08-23.png
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1036870
>
> Title:
> Multi-file download
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> Summary: Users would like to select a number of files and download
> them at once
>
> User Story
>
> Nat walks up to a KARL folder, selects 3 files and a subfolder, clicks
> Download. After answering a confirmation, they are asked to save a ZIP
> file which contains the 3 files, the sudirectory, and the items in the
> subdirectory.
>
> Specification
>
> - Button is disabled until selection, like the "Move To" and "Delete" buttons
> - If the user selects 5 files whose bytes add up to more than 20 Mb, when they click Download, display a popup telling them it is too big
> - Have to do a zip file, browsers can't do multifile download
> - In UX1 we do batching, which means they can only select files to download from one batch.
> - In UX2 we do infinite scrolling, so we can do selection anywhere in a folder
> - The confirmation popup should tell them how many items they selected. Like "Are you sure you want to download these 7 items in a ZIP file?"
> - If a subfolder is selected, make a subdirectory in the ZIP file for the folder and stick all the items in the KARL subfolder into that subdirectory
>
> Question to Carlos
>
> - How much extra to do it for both ux1/ux2? SlickGrid has a very
> different selection model.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036870/+subscriptions

[Carlos de la Guardia (cguardia)]

I just pushed a fix for the stripped absolute path warning.

[Paul Everitt (paul-agendaless)]

Jim, can you retest, just in case this fixes the problem?

--Paul

On Aug 23, 2012, at 12:07 PM, Carlos de la Guardia wrote:

> I just pushed a fix for the stripped absolute path warning.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1036870
>
> Title:
> Multi-file download
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> Summary: Users would like to select a number of files and download
> them at once
>
> User Story
>
> Nat walks up to a KARL folder, selects 3 files and a subfolder, clicks
> Download. After answering a confirmation, they are asked to save a ZIP
> file which contains the 3 files, the sudirectory, and the items in the
> subdirectory.
>
> Specification
>
> - Button is disabled until selection, like the "Move To" and "Delete" buttons
> - If the user selects 5 files whose bytes add up to more than 20 Mb, when they click Download, display a popup telling them it is too big
> - Have to do a zip file, browsers can't do multifile download
> - In UX1 we do batching, which means they can only select files to download from one batch.
> - In UX2 we do infinite scrolling, so we can do selection anywhere in a folder
> - The confirmation popup should tell them how many items they selected. Like "Are you sure you want to download these 7 items in a ZIP file?"
> - If a subfolder is selected, make a subdirectory in the ZIP file for the folder and stick all the items in the KARL subfolder into that subdirectory
>
> Question to Carlos
>
> - How much extra to do it for both ux1/ux2? SlickGrid has a very
> different selection model.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036870/+subscriptions

[JimPGlenn (jpglenn09)]

Paul, tested with IE8 and IE9 and it works great now. allows for download as a zip, provides a open/save screen and it all works.

jim

[Paul Everitt (paul-agendaless)]

Awesome. Let's mark as tested.

--Paul

On Aug 23, 2012, at 12:44 PM, JimPGlenn wrote:

> Paul, tested with IE8 and IE9 and it works great now. allows for
> download as a zip, provides a open/save screen and it all works.
>
> jim
>
> ** Tags added: tested
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1036870
>
> Title:
> Multi-file download
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> Summary: Users would like to select a number of files and download
> them at once
>
> User Story
>
> Nat walks up to a KARL folder, selects 3 files and a subfolder, clicks
> Download. After answering a confirmation, they are asked to save a ZIP
> file which contains the 3 files, the sudirectory, and the items in the
> subdirectory.
>
> Specification
>
> - Button is disabled until selection, like the "Move To" and "Delete" buttons
> - If the user selects 5 files whose bytes add up to more than 20 Mb, when they click Download, display a popup telling them it is too big
> - Have to do a zip file, browsers can't do multifile download
> - In UX1 we do batching, which means they can only select files to download from one batch.
> - In UX2 we do infinite scrolling, so we can do selection anywhere in a folder
> - The confirmation popup should tell them how many items they selected. Like "Are you sure you want to download these 7 items in a ZIP file?"
> - If a subfolder is selected, make a subdirectory in the ZIP file for the folder and stick all the items in the KARL subfolder into that subdirectory
>
> Question to Carlos
>
> - How much extra to do it for both ux1/ux2? SlickGrid has a very
> different selection model.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036870/+subscriptions

[JimPGlenn (jpglenn09)]

tested and ready for release

[Nat Katin-Borland (nborland)]

I assume this hasn't been merged to Staging b/c I'm not seeing it...

[Paul Everitt (paul-agendaless)]

Right, it's still on the branch listed in the ticket, waiting for approval.

--Paul

On Aug 29, 2012, at 5:27 PM, Nat Katin-Borland wrote:

> I assume this hasn't been merged to Staging b/c I'm not seeing it...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1036870
>
> Title:
> Multi-file download
>
> Status in KARL3:
> Fix Committed
>
> Bug description:
> Summary: Users would like to select a number of files and download
> them at once
>
> User Story
>
> Nat walks up to a KARL folder, selects 3 files and a subfolder, clicks
> Download. After answering a confirmation, they are asked to save a ZIP
> file which contains the 3 files, the sudirectory, and the items in the
> subdirectory.
>
> Specification
>
> - Button is disabled until selection, like the "Move To" and "Delete" buttons
> - If the user selects 5 files whose bytes add up to more than 20 Mb, when they click Download, display a popup telling them it is too big
> - Have to do a zip file, browsers can't do multifile download
> - In UX1 we do batching, which means they can only select files to download from one batch.
> - In UX2 we do infinite scrolling, so we can do selection anywhere in a folder
> - The confirmation popup should tell them how many items they selected. Like "Are you sure you want to download these 7 items in a ZIP file?"
> - If a subfolder is selected, make a subdirectory in the ZIP file for the folder and stick all the items in the KARL subfolder into that subdirectory
>
> Question to Carlos
>
> - How much extra to do it for both ux1/ux2? SlickGrid has a very
> different selection model.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036870/+subscriptions

[JimPGlenn (jpglenn09)]

Nat, I screwed up when I put it on the list for this release. It is still on dev., It does work fine there

[Paul Everitt (paul-agendaless)]

Assigning it to Nat for testing.

[Nat Katin-Borland (nborland)]

Looks great! Very smooth. I tested in IE9, Chrome and FF in box current KARL and UX2. I still don't have access to IE8, so I haven't checked it on that.

[Paul Everitt (paul-agendaless)]

Jim, test on IE8, and if that passes, mark as tested and tell Carlos to do a merge request.

[JimPGlenn (jpglenn09)]

This works fine under IE8