[hwclock] full path for a command possibly uncommented in init script

[glandux]

The hwclock init script /etc/init.d/hwclock.sh has a command line which can be uncommented, but don't have a full path given.
In addition, there is a typo in the comment just above: s/enablig/enabling/

This is the corresponding patch:

@@ -68,9 +68,9 @@
            # used.
            #
            # Please read /usr/share/doc/util-linux/README.Debian.hwclock
- # before enablig hwclock --adjust.
+ # before enabling hwclock --adjust.

- #hwclock --adjust $GMT $BADYEAR
+ #/sbin/hwclock --adjust $GMT $BADYEAR
            :

            if [ "$HWCLOCKACCESS" != no ]; then

[Ralph Janke (txwikinger)]

Confirmed in feisty

[Matt Zimmerman (mdz)]

Why do you feel this is a problem? The only error I see is the typo in the earlier comment ("enablig")

[Ralph Janke (txwikinger)]

I think it was filed about the inconsitency in the call of hwclock. Throughout the script it is /sbin/hwclock however, in that commented instance it is just hwclock.

- #hwclock --adjust $GMT $BADYEAR
 + #/sbin/hwclock --adjust $GMT $BADYEAR

I guess it is just cosmetic and nothing of real severity, but for the good style I think it would be good to be change for future releases.

[Matt Zimmerman (mdz)]

On Sat, Apr 07, 2007 at 12:04:21AM -0000, txwikinger wrote:
> I think it was filed about the inconsitency in the call of hwclock.
> Throughout the script it is /sbin/hwclock however, in that commented
> instance it is just hwclock.
>
> - #hwclock --adjust $GMT $BADYEAR
> + #/sbin/hwclock --adjust $GMT $BADYEAR
>
> I guess it is just cosmetic and nothing of real severity, but for the
> good style I think it would be good to be change for future releases.

I see. In that case, I'd be inclined to change it to hwclock throughout,
rather than /sbin/hwclock.

--
 - mdz

[glandux (glandux)]

Txwikinger is right in its explanations of my intentions for this bug report, it is for consistency with all others usages of hwclock command in the script (I'm sorry, I should have explain that in my report). It's not critical, and again less critical in this case because the flag is "--adjust" which not involve an important operation contrary to actions involved by "--set" or "--hctosys" flags.
I guessed that if the complete path was given for hwclock it was a precaution, and if developer of this script made this choice it may have a good raison to do that.
Normally, it can perfectly function without full path, but for the full path suppression suggested by Matt, maybe we should ensure that the choice of using full path had no particular goal which may a precaution policy (to not rely on PATH variable value for example).

Making search about that, I tried to consult the documentation file indicated in this script comments, and I noticed that the filename was not complete because of a missing extension (see bug #104467 for details).

[Ralph Janke (txwikinger)]

Waiting for upstream response

[LaMont Jones (lamont)]

Fixed in 2.13.1~rc2-1ubuntu1