pcb

EPS boundry box coordinates are float but should be int

Bug #1035999 reported by KaiMartin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Fix Released
Undecided
Unassigned

Bug Description

Currently, the EPS export of PCB produces a boundary box header with float coordinates. The standard requires integer values. Many applications don't care. But some fail, e.g. epstool. The recommended way is to give the boundry box in integer and add a HighRes header for applications that can deal with it. The attached patch does just that.

The modified header looks like this:

/------------------------------
%!PS-Adobe-3.0 EPSF-3.0
%%BoundingBox: 0 0 370 426
%%HiResBoundingBox: 0.000000 0.000000 369.503937 426.196850
%%Pages: 1
(...)
\-------------------------------

---<)kaiamartin(>---

Revision history for this message
KaiMartin (kmk-familieknaak) wrote :
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit 3fb3b329dbc56addbeb90a3777202f08eb2c303d
http://git.geda-project.org/pcb/commit/?id=3fb3b329dbc56addbeb90a3777202f08eb2c303d

commit 3fb3b329dbc56addbeb90a3777202f08eb2c303d
Author: Kai-Martin Knaak <email address hidden>
Commit: Felix Ruoff <email address hidden>

    make EPS boundingbox parameters integers Currently, the bounding box parameters given in the header of an EPS file are floats. The standard calls for integers, though. Some applications like epstool fail if the boundingbox is anything but integer. This patch uses llrint() to output the nearest integer as bounding box parameters. In addition, it adds a high resolution header for the benefit of applications that can use the extra precision.

     Example of the bounding box lines produced by the patch:
     %%BoundingBox: 0 0 370 426
     %%HiResBoundingBox: 0.000000 0.000000 369.503937 426.196850

     Closes-bug: lp-1035999

Changed in pcb:
status: New → Fix Committed
Changed in pcb:
status: Fix Committed → Fix Released
Changed in pcb:
milestone: none → pcb-20140316
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.