sh warnings in pt-summary and pt-mysql-summary

[Giovanni Bechis]

To work properly bash is still needed in pt-summary and pt-mysql-summary; patches to fix the problem added.

[Daniel Nichter (daniel-nichter)]

Thanks for the patch Giovanni.

[Daniel Nichter (daniel-nichter)]

Brian, we need to see if one of our test servers has a real /bin/sh. If so, we can test this and double-check the code for other Bash-isms.

[Daniel Nichter (daniel-nichter)]

Giovanni, this patch makes pt-summary work on on OpenBSD for you? I can't get it to work on OpenBSD 5:

$ ./pt-summary
./pt-summary[2200]: @: parameter not set

Or,

$ ./pt-summary --help
Usage:

For more information, 'man pt-summary' or 'perldoc ./pt-summary'.
...

./pt-summary[2200]: ${!varname}": bad substitution

However, it seems that changing "$@" to "${@:-""}" makes it work (except for that last ^ bad substitution error).

[Daniel Nichter (daniel-nichter)]

"${@:-""}" does seem to make pt-summary work.

Giovanni, could you please download pt-summary from http://bazaar.launchpad.net/~percona-toolkit-dev/percona-toolkit/sh-not-bash-bug-1035260/view/head:/bin/pt-summary and confirm that it works on your system too?

[Daniel Nichter (daniel-nichter)]

That "bad substitution" is fixed in r360 of that branch.

[Daniel Nichter (daniel-nichter)]

r360 pt-mysql-summary runs on my OpenBSD without errors.

[Daniel Nichter (daniel-nichter)]

Older related bug 872175

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-562