error adding "empty" tag to a track

Bug #1034510 reported by Rocco Aliberti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Low
Mathias Brodala

Bug Description

Trying to add an "empty" tag (by clicking "Add tag" in track properties, without having filled the combo field)
i got this error:

Traceback (most recent call last):
  File "/home/***/exaile/xlgui/properties.py", line 421, in _add_tag
    self._build_from_track(self.current_position)
  File "/home/***/exaile/xlgui/properties.py", line 307, in _build_from_track
    self.tags_table, f, tag, entry, i))
  File "/home/***/exaile/xlgui/properties.py", line 554, in __init__
    self.label.set_attributes(self.__changed_attributes)
AttributeError: 'TagRow' object has no attribute '_TagRow__changed_attributes'

This happens adding the first empty tag listed in the combo, and also if you, after have selected any other tag from the list, clear its name and try to add it.

Doesn't happen with the second "empty" tag in the combo. In this case, clicking the "Add tag" button the Apply button becomes available, and also this seems to me an undesirable behavior.

Related branches

Revision history for this message
Mathias Brodala (mathbr) wrote :

Fixed with r4059.

Changed in exaile:
assignee: nobody → Mathias Brodala (mathbr)
importance: Undecided → Low
milestone: none → 0.3.3.0
status: New → Fix Committed
Revision history for this message
Mathias Brodala (mathbr) wrote :

Adding nameless tags is not possible with r4079 anymore.

Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.