innochecksum is unusable and dangerous
Bug #1033677 reported by
Andrew Gaul
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Data Recovery Tool for InnoDB |
Fix Committed
|
High
|
Aleksandr Kuzminsky | ||
Bug Description
innochecksum has three significant bugs: spuriously writing to FIL_PAGE_LSN, calculating the old- and new-style checksums in the wrong order, and smashing adjacent fields on x86-64. The program is unusable and dangerous as-is. I submitted fixes to all symptoms:
https:/
https:/
https:/
Related branches
lp:~gaul/percona-data-recovery-tool-for-innodb/calculate-new-checksum-first
- Aleksandr Kuzminsky (community): Approve
-
Diff: 94 lines (+37/-29)2 files modifiedinclude/innochecksum.h (+8/-0)
innochecksum.c (+29/-29)
lp:~gaul/percona-data-recovery-tool-for-innodb/fixed-width-checksum
- Aleksandr Kuzminsky (community): Approve
-
Diff: 20 lines (+2/-1)1 file modifiedinnochecksum.c (+2/-1)
lp:~gaul/percona-data-recovery-tool-for-innodb/do-not-write-lsn
- Aleksandr Kuzminsky (community): Approve
-
Diff: 20 lines (+1/-2)1 file modifiedinnochecksum.c (+1/-2)
| Changed in percona-data-recovery-tool-for-innodb: | |
| importance: | Undecided → High |
| assignee: | nobody → Aleksandr Kuzminsky (akuzminsky) |
| Changed in percona-data-recovery-tool-for-innodb: | |
| status: | New → Fix Committed |
| milestone: | none → release-0.6 |
To post a comment you must log in.
