MIDI input / output matching support for Traktor X1

Bug #1033375 reported by Ilkka Tuohela
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Ilkka Tuohela

Bug Description

Traktor X1 device matches the existing 'to' name matching rule incorrectly (TrakTOr), the rule should match beginning of string or ' to ' and ' from ' if middle of string matches are required.

Additionally, the X1 input and output device names contain strings ' input port ' and ' output port ' and linking the devices does not support.

Attached patch fixes both issues.

Revision history for this message
Ilkka Tuohela (hile) wrote :
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

This code is now changed -- could you update the patch? Also, could you add a specific unit test to src/test/portmidienumerator.cpp (next to the others) using the exact strings the X1 shows up as to verify that they are correctly matched now (so that we don't break this in the future)?

Changed in mixxx:
milestone: none → 1.11.1
importance: Undecided → Low
assignee: nobody → Ilkka Tuohela (hile)
status: New → In Progress
Revision history for this message
Ilkka Tuohela (hile) wrote :

New pull request from my git fork added to address this issue against new code.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

This will be in 1.12.0.

Changed in mixxx:
milestone: 1.11.1 → 1.12.0
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6599

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.