Multiple magnet links in one message causes a crash

Bug #1032227 reported by Skip de Groot
258
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Critical
Unassigned

Bug Description

Pasting two magnet links in one message to the hubchat will cause the 0.799 client to crash.

This happend on a ~200 user LAN hub running PtokaX DC Hub 0.4.2.0

The crash happened after the following message (Copied from linuxdcpp client which does not crash)

<[T4L]DJ_AD-HD> maar voor wie ze wil hebben de magnet links magnet:?xt=urn:tree:tiger:H5K2DYQC7U2H6DVGRPLCSNC3MH2UXBDWIKAMFEY&xl=413253784&dn=WoT_0.7.5_eu_patch.exe magnet:?xt=urn:tree:tiger:GNPE66SMDITMA6JXLWCTCRDSY7ALZXLJJWYKLAA&xl=3540652293&dn=WoT_0.7.5_eu_setup.exe

This caused hundreds of clients to crash so it's probably not limited to a certain PC configuration, but DC++ 0.782 did not crash.

Revision history for this message
eMTee (realprogger) wrote :

Confirmed with DC++ rev3013 on WinXP. It displays the Microsoft Runtime dialog immediately. No backtrace.
Does not seem to effect other clients, eg. it does not crash DiCe++ r135 either, so I suspect this must be something with the new way of Magnet formatting.

Changed in dcplusplus:
status: New → Confirmed
importance: Undecided → Critical
Revision history for this message
poy (poy) wrote :

fixed in rev 3019.

thanks for the report, Skip. your discretion is appreciated as the next DC++ is not quite ready for a release yet.

Changed in dcplusplus:
status: Confirmed → Fix Committed
security vulnerability: yes → no
Revision history for this message
Skip de Groot (skipdegroot) wrote :

No problem, but this issue arose on a LAN of ~ 800 people with quite a bit of technical skills so it might be out in the open earlier then you might think.

Nice to see such a quick response though and thanks for all the hard work on DC++! :)

Revision history for this message
poy (poy) wrote :

Fixed in DC++ 0.800.

visibility: private → public
Changed in dcplusplus:
status: Fix Committed → Fix Released
eMTee (realprogger)
security vulnerability: no → yes
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.