Config should preserve case of setting

[Curt Moore]

When reading a config from a file, config.py currently performs a lower() operation on any setting keys read from the configuration file. In the event that the config file contains a camelCase configuration option, this option is lowercased. When the config is re-written to disk, the result is that we have two copies of the same config setting key, one camelCase and one lowercase.

The attached patch does not lowercase the settings keys upon reading them, resulting in only one config option being written to disk.

[Jelmer Vernooij (jelmer)]

I'm not sure if this is the right fix - lookups should be case insensitive, that's why we lower case the setting.

Any chance you can add a unit test for this?

[milki (milki-p)]

On 14:24 Sun 16 Sep , Jelmer Vernooij wrote:
> I'm not sure if this is the right fix - lookups should be case
> insensitive, that's why we lower case the setting.

lookups should be case insensitive, but I believe the case should be
preserved in the file itself. That's why in my approach to config, I
explicitly had a key that contained the original case of the config in
'_name'

https://github.com/milki/dulwich/commit/2595eb32b0bfda5667c384bca5dad7f23a485b93

-milki

[Jelmer Vernooij (jelmer)]

Yeah, I agree lookups be case insensitive but we should preserve case.