Improve finding PHP
Bug #1029783 reported by
Chris Hillery
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zorba |
Fix Released
|
Low
|
Rodolfo Ochoa | ||
Bug Description
Our PHP doc says you have to specify PHP5_BINARY_DIR, PHP5_INCLUDE_DIR, and PHP5_LIBRARY manually to build Zorba with the appropriate bindings.
This should be more automated - our FindPHP5.cmake should be enhanced so that the user needs only to set CMAKE_PREFIX_PATH to point to a common root and all things will be found.
It looks like this might already be true for PHP5_INCLUDE_DIR, but PHP5_BINARY_DIR is used as a PATHS for finding the php5 binary which isn't normal. And PHP5_LIBRARY isn't set by FindPHP5.cmake at all - swig/php/
Related branches
lp:~zorba-coders/zorba/bug1001474
- Chris Hillery: Approve
- Rodolfo Ochoa: Approve
-
Diff: 150 lines (+56/-14)4 files modifiedcmake_modules/FindPHP5.cmake (+11/-0)
modules/DownloadModules.cmake (+39/-14)
src/compiler/expression/pragma.cpp (+1/-0)
swig/python/CMakeLists.txt (+5/-0)
| Changed in zorba: | |
| importance: | Undecided → Low |
| assignee: | nobody → Rodolfo Ochoa (rodolfo-ochoa) |
| Changed in zorba: | |
| status: | New → Fix Committed |
| Changed in zorba: | |
| milestone: | none → 2.9 |
| Changed in zorba: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
