There's no way to set a custom target prompt string
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
LAVA Dispatcher |
Fix Released
|
Medium
|
Spring Zhang |
Bug Description
Currently, the lava-dispatcher component set the target image (the one that will run the tests, not the master) to have a hostname called "linaro", by changing the /etc/hostname file. It also expects that the prompt string to have the 'linaro' string that it has set.
However, in some cases and images, we might want to set a different string from 'linaro'. A custom one that will represent better that target image. Thus, I suggest to have a device config option where we could set the target hostname depending on the image/device/
A configuration var called HOSTNAME_STR would be enough, as can be seen here: http://
However, I believe that the best way to implement it is changing the name of the current property 'hostname' defined inside the client/base.py. This property returns not the hostname, but the defined device name (which is the file name that represents the device inside the dispatcher configuration dir), which is used by conmux.
I believe that we could use the 'hostname' property to return the real defined hostname (as I suggested above by using HOSTNAME_STR) and create a new property that would represent the device name created inside the dispatcher config dir (which today is the hostname property). I guess it would make things more consistent and clear.
Related branches
- Andy Doan (community): Approve
-
Diff: 89 lines (+17/-5)6 files modifieddoc/changes.rst (+4/-2)
lava_dispatcher/client/base.py (+4/-0)
lava_dispatcher/client/fastmodel.py (+2/-1)
lava_dispatcher/client/master.py (+2/-1)
lava_dispatcher/client/qemu.py (+2/-1)
lava_dispatcher/default-config/lava-dispatcher/device-defaults.conf (+3/-0)
Changed in lava-dispatcher: | |
assignee: | nobody → Spring Zhang (qzhang) |
importance: | Undecided → Medium |
milestone: | none → 2012.08 |
status: | New → Fix Committed |
Changed in lava-dispatcher: | |
status: | Fix Committed → Fix Released |
Our device- defaults. conf has an option:
TESTER_STR = root@linaro
Could you not update that to do what you are wanting?