Test code can leave stale fasls

Bug #1026658 reported by Robert P. Goldman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ASDF
Won't Fix
Low
Robert P. Goldman

Bug Description

I found a bug in the ECL of MacPorts, that caused the tests to fail. Working with the MacPorts folks, I fixed the version of ECL, and tried to rerun the tests, which still failed. This happened because the fasls created by the failed test run were not wiped out.

Suggest we should make sure the asdf/tmp/fasls directory is wiped out after every run-tests.sh, or that we smash it before every call to run-tests.sh

Revision history for this message
Faré (fahree) wrote :

Is this still an issue?

The tests now use output-translations for about everything but asdf itself, which should avoid FASL clash effects.

Marking as Incomplete and assigning back at rpgoldman to check whether there's still an issue.

Changed in asdf:
assignee: nobody → Robert P. Goldman (rpgoldman)
importance: Undecided → Low
milestone: none → version3
status: New → Incomplete
Revision history for this message
Robert P. Goldman (rpgoldman) wrote :

I'm not sure whether this is still an issue or not. Note that this wasn't a fasl *clash* issue, it was the presence of fasls changing the test behavior (e.g., no compilation happening, because of fasl left around from last tests). Seems like I'm getting fasls now in build/fasls/ for the tests.

Do we need to take precautions to smash these before running tests?

Revision history for this message
Faré (fahree) wrote :

It's always nicer to clean before running tests.

Now, I've spent a LOT of time making tests robusts during my work leading to ASDF 3,
so it's very likely that whatever specific instability you observed has been fixed.

I would close this bug somehow, hoping the bug doesn't exist — you can reopen if it appears again.

Revision history for this message
Faré (fahree) wrote :

Closing as "Won't Fix", lacking a better code name such as "Unable To Reproduce", or "Hopefully Already Fixed".

Changed in asdf:
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.