File system monitor imports are messy
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Client | Status tracked in Trunk | |||||
Stable-4-0 |
Fix Released
|
Undecided
|
Unassigned | |||
Trunk |
Fix Released
|
Medium
|
Manuel de la Peña |
Bug Description
From comments regarding the code:
I looked at the assignment to get_filemonitor
a bit - some of this isn't new in this diff, but might be
nice to fix here, instead of adding code that does the same thing:
(Feel free to disagree if you think it's not productive)
# why is get_filemonitor
it looks like it's never accessed as
filesystem_
filesystem_
platform/
So, that assignment is unnecessary, and
# importing filesystemMonitor - there are a lot of ways to import
it. I think we could remove the assignments in platform/
and filesystem_
just get it from platform.
everywhere - we already do this in a few places.
- syncdaemon/
platform.
from platform. (seems like those should be the same)
- test_windows and test_darwin import it from
u.platform.
gets it from platform.
# related to the above: _GeneralINotify
used in test_filesystem
remove the assignment in filesystem_
Related branches
- Mike McCracken (community): Approve
- Alejandro J. Cura (community): Approve
-
Diff: 70 lines (+9/-9)2 files modifiedtests/platform/filesystem_notifications/test_filesystem_notifications.py (+6/-8)
ubuntuone/syncdaemon/event_queue.py (+3/-1)
Changed in ubuntuone-client: | |
status: | Triaged → In Progress |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |