pantheon-files crashed with SIGSEGV in trash_or_delete_internal()

[Bobby Hiltz]

crash while performing alt-tab

ProblemType: Crash
DistroRelease: elementary 0.2
Package: pantheon-files 0.1-0~r885+pkg8~precise1 [origin: LP-PPA-elementary-os-daily]
ProcVersionSignature: Ubuntu 3.2.0-26.41-generic 3.2.19
Uname: Linux 3.2.0-26-generic x86_64
ApportVersion: 2.0.1-0ubuntu8+elementary3~precise1
Architecture: amd64
CrashCounter: 1
CrashDB: pantheon_files
Date: Wed Jul 18 15:02:28 2012
ExecutablePath: /usr/bin/pantheon-files
InstallationMedia: elementary OS 0.2 "Luna" - Build amd64 LIVE Binary 20120612-17:45
ProcCmdline: pantheon-files
ProcEnviron:
 PATH=(custom, no user)
 LANG=fr_FR.UTF-8
 SHELL=/bin/bash
SegvAnalysis:
 Segfault happened at: 0x7fe707388034: mov 0x0(%rbp),%rdi
 PC (0x7fe707388034) ok
 source "0x0(%rbp)" (0x00000000) not located in a known VMA region (needed readable region)!
 destination "%rdi" ok
SegvReason: reading NULL VMA
Signal: 11
SourcePackage: pantheon-files
StacktraceTop:
 ?? () from /usr/lib/libmarlincore.so.0
 ?? ()
 ?? ()
 ffi_call_unix64 () from /usr/lib/x86_64-linux-gnu/libffi.so.6
 ffi_call () from /usr/lib/x86_64-linux-gnu/libffi.so.6
Title: pantheon-files crashed with SIGSEGV in ffi_call_unix64()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

[RabbitBot (rabbitbot-a)]

StacktraceTop:
 trash_or_delete_internal (files=0x0, parent_window=<optimized out>, try_trash=1, done_callback=0x4403b0 <marlin_mime_get_applications_for_files+368>, done_callback_data=0x2751a00) at /build/buildd/pantheon-files-0.1/libcore/marlin-file-operations.c:2078
 trash_or_delete_files (files=<optimized out>, view=<optimized out>, delete_if_all_already_in_trash=<optimized out>) at /build/buildd/pantheon-files-0.1/src/fm-directory-view.c:2637
 trash_or_delete_selected_files (view=0x2751a00) at /build/buildd/pantheon-files-0.1/src/fm-directory-view.c:2662
 trash_or_delete_files (files=0x7fff9c356570, view=0x10, delete_if_all_already_in_trash=<optimized out>) at /build/buildd/pantheon-files-0.1/src/fm-directory-view.c:2644
 trash_or_delete_selected_files (view=0x10) at /build/buildd/pantheon-files-0.1/src/fm-directory-view.c:2662

[Cody Garver (codygarver)]

Not sure how to reproduce, but the retrace is the same across all duplicates.

[Julián Unrrein (junrrein)]

The last function called are these:
trash_or_delete_files -> marlin_file_operations_trash_or_delete -> trash_or_delete_internal

trash_or_delete_files ensures that the file list passed to marlin_file_operations_trash_or_delete (which is then directly passed to trash_or_delete_internal) is not null (as of rev1031).

But in the stack trace we can see that trash_or_delete_internal received "files=0x0" - it's null! This should never happen.

We could add another check to see if the file list is null in either marlin_file_operations_trash_or_delete or trash_or_delete_internal, but I don't see the point - the check is already in place in trash_or_delete_files. Adding another one wouldn't change anything.

Even if it would, how can we check if that fixes the bug? We still need a way to reproduce the bug.