python-mkdebian generates malformed copyright strings in debian/copyright

Bug #1025491 reported by Aaron Haviland
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
python-distutils-extra
Fix Released
Undecided
Andrew Starr-Bochicchio
python-distutils-extra (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

I first found the issue reported here: http://askubuntu.com/questions/162718/quickly-creates-wrong-debian-copyright-file
and I am seeing the same output.

When generating debian/copyright, python-mkdebian appears to be pulling copyright lines from multiple files which is fine, but then I end up with a section of debian/copyright that looks like this:

Files: *
Copyright: (C) 2012 Aaron Haviland &lt;<email address hidden>&gt;
Copyright: (C) 2012 Aaron Haviland &lt;<email address hidden>&gt;</property>
Copyright: (C) 2012 Aaron Haviland <email address hidden>

The bad lines are coming from data/ui/AboutKwiklyDialog.ui:

./data/ui/AboutKwiklyDialog.ui: <property name="copyright" translatable="yes">Copyright (C) 2012 Aaron Haviland &lt;<email address hidden>&gt;</property>
./data/ui/AboutKwiklyDialog.ui: <property name="license" translatable="yes"># Copyright (C) 2012 Aaron Haviland &lt;<email address hidden>&gt;
./data/ui/AboutKwiklyDialog.ui: <property name="authors">Copyright (C) 2012 Aaron Haviland &lt;<email address hidden>&gt;</property>

Tags: arb
Revision history for this message
Aaron Haviland (aaron-haviland) wrote :

While I'm not sure if the attached patch is the best solution, it certainly seems the easiest: Ignore the Glade .ui files when searching for copyright strings.

Revision history for this message
Aaron Haviland (aaron-haviland) wrote :

Addendum: I suspect we should also not look at backup files (*~) for the same reason.

Updated patch.

Revision history for this message
Marian Lux (reg-mlux) wrote :

I think this bug also blocks me to upload my app to the Ubuntu Software Center. Is this patch a workaround? How can I install this?
Here is my app-project:
https://myapps.developer.ubuntu.com/dev/apps/1172/feedback/

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

I can confirm this. In every app made with quickly I reviewed as an ARB "helper" for the recent App Showdown, this had to be manually fixed.

Changed in python-distutils-extra:
status: New → Confirmed
tags: added: arb
Changed in python-distutils-extra:
assignee: nobody → Andrew Starr-Bochicchio (andrewsomething)
status: Confirmed → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Merged Andrews' fix into trunk r308.

Changed in python-distutils-extra:
status: In Progress → Fix Released
Changed in python-distutils-extra (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-distutils-extra - 2.37-1

---------------
python-distutils-extra (2.37-1) unstable; urgency=low

  [ Martin Pitt ]
  * auto.py: Recognize manpages which have comments before the initial .TH
    comment. Thanks to Dominique Lasserre for the initial patch!
    (LP: #893337)

  [ Andrew Starr-Bochicchio ]
  * debian/local/python-mkdebian: Handle Glade .ui files correctly when
    generating the copyright file. Also ignore backup files.
    (LP: #1025491)

python-distutils-extra (2.36-1) unstable; urgency=low

  * debian/rules: Run tests against all supported python 2 and 3 versions.
    This catches bugs with Python 2.6. (Closes: #684967)
  * debian/rules: Skip tests if $DEB_BUILD_OPTIONS contains "nocheck".
    (Closes: #684966)
  * debian/rules: Run tests under LC_ALL=C, to fix FTBFS in cases where
    LC_CTYPE is set explicitly. Thanks Gregor Hermann!
  * auto.py: Use python 2.6 friendly sys.version_info test. Thanks Salvatore
    Bonaccorso and Gregor Hermann! (First half of #682631)
  * auto.py: Do not call decode() with an "errors" keyword, as this does not
    yet work with Python 2.6. Thanks Gregor Hermann! (Closes: #682631)
 -- Martin Pitt <email address hidden> Mon, 17 Sep 2012 12:47:44 +0200

Changed in python-distutils-extra (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.