Filenames on the Desktop can't be seen properly with light backgrounds

Bug #1025443 reported by Aditya V
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Salience
Fix Released
Medium
Christopher Kyle Horton

Bug Description

To test:

Get a light background (pure white works, too) and copy a file to the desktop. Its name can barely be seen.

Using Nautilus as the desktop manager.

Tags: gtk-3

Related branches

Aditya V (kroq-gar78)
description: updated
Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

You mean you are getting something like this? Maybe we should see if there's a way to increase/darken the text shadow?

Changed in salience:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Aditya V (kroq-gar78) wrote : Re: [Bug 1025443] Re: Filenames on the Desktop can't be seen properly with light backgrounds

Yep, that's exactly what I mean. I think we should create a separate .css
file for this in gtk-3.0/apps/.

I'm not sure if this is possible (need to look at how Ambiance goes about
fixing this), but maybe we can add a colored box around the text or
something.

Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

I just pushed r57 to trunk which darkens the text shadows a bit. Let me know if it's still an issue.

I myself would like a slight shadow going in all directions around the text, like a blurry outline (instead of just being a darker version of the same text offset by one pixel), but I'm not sure if that's possible, or how one would go about doing that.

Changed in salience:
assignee: nobody → Christopher Kyle Horton (christhehorton)
status: Triaged → In Progress
Revision history for this message
Aditya V (kroq-gar78) wrote :

Nope, still doesn't fix it. Attached is an image comparing Salience and
Ambiance (left and right sides, respectively).

Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

Okay, in Ambiance it appears that the text shadow is being offset both horizontally and vertically, while in Salience r57 and below it is only being offset vertically. I changed Salience in r58 to also have a horizontal offset (albeit in a different direction), in addition to an unrelated change where I removed the text shadow for selected items.

How does it look now?

(Note: all of my changes are being made in gtk-3.0/desktop-items.css, so no need for a separate CSS file, we already have one. :) )

Revision history for this message
Aditya V (kroq-gar78) wrote :

No, still not yet. Maybe just copy the same settings from Ambiance to Salience? They both use white as the desktop item color.

Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

...okay, hopefully r61 does the trick. I found out that you actually can define multiple shadows on something using a comma-separated list.

Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

I'm marking as Fix Committed for now since I don't think the problem exists now. We now have a shadow for desktop items that goes all around the text label. Feel free to re-open if this still isn't satisfactory; in particular, let me know if the shadow is dark enough.

Changed in salience:
status: In Progress → Fix Committed
milestone: none → 1.0
Revision history for this message
Aditya V (kroq-gar78) wrote :

Yup, looks good. Retargeting for 1.0-beta.

Changed in salience:
milestone: 1.0 → 1.0-beta
Changed in salience:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.