Backend functions allow hold placement at invalid pickup locations

[Thomas Berezansky]

As more third party products are integrating with Evergreen and potentially doing things like placing and editing holds the backend functions should protect input better, rather than relying on the front end.

Hold placement and pickup libraries is one of these places. While the official frontends protect bad pickup locations fairly well third parties may not be as careful. Thus the backend should probably generate an error when a bad pickup location is specified. I personally feel that the error should not be allowed to be overridden as even staff interfaces do not allow selection of *any* location for pickup, even if they show locations that are not OPAC Visible.

[[e-mail] (tji)]

Another place is the hold selection depth. Sometimes with the change of pickup library, the hold selection depth should be adjusted as well to avoid holds being filled by a wrong copy (outside the boundary) or being unfillable (no holdable copy within the boundary).

We also notice the lack of protection on the staff client. Once a hold is placed, staff is free to edit the pickup location to anywhere regardless the hold policy and boundaries. The selection depth is not adjusted accordingly.

[Jason Boyer (jboyer)]

Another situation where this comes up is old browsers that don't support the disabled attribute of option elements (Old IE for one). We've had multiple holds placed with pickup locations of the library system rather than one of its branches.