Need to correctly discover XCP and XenServer versions

[John Garbutt]

XenServer 6.0.x / XCP 1.5 has a new "platform version" flag we can use that is shared between XCP and XenServer.
We can fallback to XenServer version when "platform version" is missing.

See also bug 1033933.
See also bug 1016650.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10720

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10873

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10874

[Johannes Erdfelt (johannes.erdfelt)]

Is there any documentation on the platform version? Like what platform version did VDI.resize_online get renamed to VDI.resize?

It certainly sounds like the preferred way to select features, but I don't know how to figure out the correct values for it.

[John Garbutt (johngarbutt)]

This is related to this bug:
https://bugs.launchpad.net/nova/+bug/1016650

This is the documentation, however this claims both operations have been available since XenServer 4.0:
http://docs.vmd.citrix.com/XenServer/6.0.0/1.0/en_gb/api/?c=VDI

I have a feeling this may be because people where using the LVM SR rather than EXT SR.

[John Garbutt (johngarbutt)]

No longer valid

[John Garbutt (johngarbutt)]

It has been fixed by the referenced bugs