Use GIT_SSH

[Tisza Gergő]

Git allows setting the SSH client via the GIT_SSH environmental variable. This is quite useful on Windows/msysgit to use an SSH client which is integrated with Windows (such as plink) so that one only has to enter the passphrase once per reboot, but git-review calls "ssh" regardless of the GIT_SSH setting (which means one needs to enter the passphrase once for every git shell opened). Honoring the GIT_SSH setting would make git-review much more convenient to use on Windows.

[Marcin Cieślak (saperski)]

Good idea, but we also call "scp", which could (maybe) be replaced with "pscp.exe" as well (there is even bug 1024073 about fixing paths for msysgit ssh). There is no GIT_SCP probably; should path to SCP be inferred from GIT_SSH (like replace "ssh" -> "scp", "plink" -> "pscp")?

[Marcin Cieślak (saperski)]

But possibly we could just use SSH (as scp does)

plain "scp gerrithost hooks/commit-msg"

seems to be equivalent to

"ssh -x -oForwardAgent=no -oPermitLocalCommand=no -oClearAllForwardings=yes -- gerrithost scp -f hooks/commit-msg"

[Marcin Cieślak (saperski)]

Proposed solution on the mailing list http://lists.openstack.org/pipermail/openstack-infra/2013-January/000023.html by using something like https://github.com/saper/simple-scp-client instead of external scp client. Would also help with bug 1024073.