RpcZmqBaseTopicTestCase Fails due to unsupported string formatting

Bug #1023039 reported by Jason Kölker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-common
Fix Released
Undecided
Jason Kölker

Bug Description

diff --git a/openstack/common/rpc/impl_zmq.py b/openstack/common/rpc/impl_zmq.py
index 3eefa96..b328c3b 100644
--- a/openstack/common/rpc/impl_zmq.py
+++ b/openstack/common/rpc/impl_zmq.py
@@ -119,9 +119,9 @@ class ZmqSocket(object):
         for f in do_sub:
             self.subscribe(f)

- LOG.debug(_("Connecting to %{addr}s with %{type}s"
- "\n-> Subscribed to %{subscribe}s"
- "\n-> bind: %{bind}s"),
+ LOG.debug(_("Connecting to %(addr)s with %(type)s"
+ "\n-> Subscribed to %(subscribe)s"
+ "\n-> bind: %(bind)s"),
                   {'addr': addr, 'type': self.socket_s(),
                    'subscribe': subscribe, 'bind': bind})

diff --git a/tests/unit/rpc/test_zmq.py b/tests/unit/rpc/test_zmq.py
index d77850e..61317bf 100644
--- a/tests/unit/rpc/test_zmq.py
+++ b/tests/unit/rpc/test_zmq.py
@@ -97,7 +97,7 @@ class _RpcZmqBaseTestCase(common.BaseRpcTestCase):
         except OSError:
             assert False, _("Could not create IPC directory %s") % (ipc_dir, )
         finally:
- super(RpcZmqBaseTestCase, self).setUp(
+ super(_RpcZmqBaseTestCase, self).setUp(
                 topic=topic, topic_nested=topic_nested)

     def tearDown(self):

Changed in openstack-common:
status: New → Confirmed
assignee: nobody → Jason Kölker (jason-koelker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/9594

Changed in openstack-common:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-common (master)

Reviewed: https://review.openstack.org/9594
Committed: http://github.com/openstack/openstack-common/commit/44beb84b48051ff374bde6088688d6759a1807eb
Submitter: Jenkins
Branch: master

commit 44beb84b48051ff374bde6088688d6759a1807eb
Author: Jason Kölker <email address hidden>
Date: Tue Jul 10 11:12:50 2012 -0500

    Fix Zmq so it doesn't rely on nova flags

    * Embeded newlines in logging makes me cry
    * String formatting uses parens not curly braces
    * Fix LP1023039
    * Hard skip Zmq tests so jenkins passes. Someone will have to fix.

    Change-Id: I9b12ac47b02edf1d8dba7236550deb8ee33f5e07

Changed in openstack-common:
status: In Progress → Fix Committed
Mark McLoughlin (markmc)
Changed in openstack-common:
milestone: none → 2012.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.