Ctrl+C increments the documents count

[jazzynico]

Each time an object is added in the clipboard, the document count increases. Steps:
a. Open a new document with Ctrl+N.
b. The new document is labeled New document 2.
c. Create an object and copy it.
d. Open a new document with Ctrl+N.
e. The new document is labeled New document 4 (or 5 if you pressed Ctrl+C twice, and so on).

Reproduced on Windows XP, Inkscape 0.47, 0.48.3.1 and trunk revision 11533.
Not reproduced with 0.46 (old regression).

[rickmastfan67 (rickmastfan67)]

I can reproduce this in Windows 7, Inkscape 0.48.3.1, as well.

[su_v (suv-lp)]

Reproduced with Inkscape 0.47, 0.48.2, 0.48.3.1 and 0.48+devel r11533 on OS X 10.7.4.
Not reproduced with Inkscape 0.46 on Mac OS X 10.5.8.

[Maggio (dev-maggio)]

Hello,

I have fixed this bug by adapting the creation of the name of document. A new static counter has been added for differentiate internal documents and user documents.

see the attachment.

[Maggio (dev-maggio)]

Each time an object is modified(Fill/Stroke,Gradient...), the document count increases. Steps:
a. Open a new document with Ctrl+N.
b. The new document is labeled New document 2.
c. Create an object and change stroke.
d. Open a new document with Ctrl+N.
e. The new document is labeled New document 4 (or 5 if you changed stroke twice, and so on).

This seconde patch fixe it:

[jazzynico (jazzynico)]

Tested on Debian testing, Inkscape trunk revision 12025.
The fix looks good, no regression found so far.

For convenience, here's an unified version of your patches.

[jazzynico (jazzynico)]

Fixed in the trunk, revision 12340.
Thanks, Maggio!

[su_v (suv-lp)]

@JazzyNico - revision 12340 introduces a regression: saving a new document overwrites the default template file instead of asking for a new file name (and 'Save as' also proposes to overwrite the default template). Happens with all local builds on OS X 10.7.5, as well as on Ubuntu 12.10 (VM, 64bit). Not reproduced with r12339.

Would you prefer me to file a new report, or to reopen this one?

[su_v (suv-lp)]

> revision 12340 introduces a regression: saving a new document
> overwrites the default template file instead of asking for a new file name

Sample steps to reproduce:
1) launch current trunk by itself
2) modify the 'New Document' (e.g. draw a rect)
3) save (Ctrl+S)

Expected result:
The file dialog opens and prompts for file name (default: 'drawing.svg') and location.

Actual result:
The default template is resaved with the content of the current 'New Document'.

[jazzynico (jazzynico)]

Patch reverted revision 12341.

~suv> Would you prefer me to file a new report, or to reopen this one?

I think it's safer to revert the fix and work on the regression with a new patch.

[jazzynico (jazzynico)]

Here's a new patch version that should work as expected (tested on Windows XP, Inkscape trunk revision 12397).
Please test!

[jazzynico (jazzynico)]

Modified patch from comment #11 tested successfully on Crunchbang Waldorf (Debian stable) and committed revision 12712.

[jazzynico (jazzynico)]

Too many changes in the trunk, and porting to the branch would be a bit too risky IMHO. Removing the backport-proposed tag.