konquets existsing game aborts without warning if new selected from game menu

[michael]

konquest exectutes the following on selecting game->new.
MainWindow::startNewGame()
{
    m_gameView->deleteLater();
    m_game->deleteLater();
    setupGameView();
    m_gameView->startNewGame();
}

By calling setupGameView(); we are aborting the current game regardlless of whether or not the new game dialog is cancled. This should only only be done if GameView::shutdownGame() returns true. Further, since startNewGame is called on the new GameView it will never display confirmation before terminating the existing game.
Edit: Just realized I patched my 4.8.3 copy too.

[michael (reeves-87)]

Sorry I had a little trouble with the interface. Upstream has fixed this in commit 0f4655733289d6703db20d89d9d49b7732d303fd. Please see https://git.reviewboard.kde.org/r/108460/. I am requesting that this patch be back-ported to kde 10 as well. Next kde release will have it if nothing else.

[michael (reeves-87)]

Fixed upstream as of kde 4.10.2. See https://bugs.kde.org/show_bug.cgi?id=316623. Commit at http://commits.kde.org/konquest/ac85b0308b3f0886aa3c749cfe0ac1673986a0ba

[michael (reeves-87)]

kubuntu-ppa just got kde 4.10.2 which fixes the issue. Raring should be getting this too https://wiki.kubuntu.org/RaringRingtail/Beta2/Kubuntu.