Presentation module crashes when importing powerpoint files

[Glen Lockwood]

Windows XP Professional SP3, Powerpoint 2003

OpenLP 1.9.10 On importing prestentions program crashes. This did not occur on version 1.9.9. Error log text file attached. On reentry to OpenLPfile names are present with no thumbnail and adding them to service causes another crash.

Traceback (most recent call last):
File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.core.lib.mediamanageritem", line 344, in onFileClick
File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.core.lib.mediamanageritem", line 400, in validateAndLoad
File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.plugins.presentations.lib.mediaitem", line 197, in loadList
File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.plugins.presentations.lib.powerpointcontroller", line 138, in load_presentation
File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\out01-PYZ.pyz\openlp.plugins.presentations.lib.powerpointcontroller", line 159, in create_thumbnails
File "<COMObject <unknown>>", line 3, in Export
com_error: (-2147352567, 'Exception occurred.', (0, u'Microsoft Office PowerPoint 2003', u'Slide.Export : The path or file name for F://Rockdale%20Corps%20Church/SUNDAY%20WORSHIP/Song%20Word%20openLP/presentations/thumbnails/Announcements%20-%20Sunday%208th%20July%202012.ppt/slide1.png is invalid. Please check that the path and file name are correct.', u'', 0, -2147467259), None)

[Phill (phill-ridout)]

The forward slashes and %20's look suspicious in the file name.

File "<COMObject <unknown>>", line 3, in Export
com_error: (-2147352567, 'Exception occurred.', (0, u'Microsoft Office PowerPoint 2003', u'Slide.Export : The path or file name for F://Rockdale%20Corps%20Church/SUNDAY%20WORSHIP/Song%20Word%20openLP/presentations/thumbnails/Announcements%20-%20Sunday%208th%20July%202012.ppt/slide1.png is invalid. Please check that the path and file name are correct.', u'', 0, -2147467259), None)

[Glen Lockwood (glen-lockwood)]

This error seems to occur using either network or local hard drive since the ability to run a custom directory for files has been added. The program cannot create thumbnails. If dummy thumbnails are created and placed in the appropiate directory, it stops this crash from occuring. A PC running Windows 7 on the same network does not have the same problem.

[Andreas Preikschat (googol-deactivatedaccount)]

I cannot reproduce this (linux user). But if it is as described then it should be fixed in the next release.

[Phill (phill-ridout)]

Andreas, what do you think fixed this?

[Glen Lockwood (glen-lockwood)]

I think that some how it may be addressing the drive as a web address hence the "%20" in the filenames? I'm not sure if this is triggered by OpenLP or the way the network drive is set up, but its ok on windows 7.

[John Cegalis (jseagull1)]

Using 2050 on Win7 with PPT 2007 using a custom directory I cannot reproduce this bug. I did the same thing on XP with PPT 2003 using a custom directory and could not reproduce this.

[John Cegalis (jseagull1)]

After Jonathan's email I added a space to my custom directory and when I re-opened OpenLP after adding a couple of ppt files the files it showed an X instead of the thumbnail but still displayed and I did not get a crash. The only thing I noticed is the X in place of the thumbnail.

[Jonathan Corwin (j-corwin)]

Please could you attach a debug log, and also could you do a File -> Export Settings and attach that too.
Thanks.

[Stevan Pettit (elderp-deactivatedaccount)]

I can duplicate this error.

The error occurs when the data files are located on a network drive AND the presentation name contains blanks.

My custom data path was -> O:\OpenLPData\Data

[Stevan Pettit (elderp-deactivatedaccount)]

The error does not occur on Windows 7. Appears to be XP specific.

[Stevan Pettit (elderp-deactivatedaccount)]

I'll look into this. I'll have to build on Win 7 and then test on XP

[Stevan Pettit (elderp-deactivatedaccount)]

This problem also occurs if the data folder is changed to a local directory and that directory name contains a "space".

The "real" problem is QtGui.QFileDialog.getExistingDirectory(.....

On XP, when a directory is selected, the dialog returns [drive]:/[directory/directory....] instead of [drive]:\[directory\directory...]

On Win 7, the path name is returned correctly.

This normally does not cause a problem in OpenLP, until this path is passed to the powerpoint dll. For ome reason, when it sees the "/", all spaces in the string are changed to &20 (substitution for a space) which then causes the problem.

I changed the "/"'s to "\" in the registry for the data path name, and the error went away.