Color scheme support in skins partially broken when using stylesheets

Bug #1021031 reported by jus
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
RJ Skerry-Ryan

Bug Description

Just read in http://mixxxblog.blogspot.de/2012/06/mixxx-1101-released.html#comment-form that there is an issue with 1.11 beta1 skins that make use of the color scheme support in Mixxx ( currently only the OUTLINE skins) in . This is also follow up to the color scheme issues reported in https://bugs.launchpad.net/mixxx/+bug/921174/comments/1

For 1.11 skins we use a global declaration for styling the tooltip. Apparently this interferes with <NumberBpm>,<Text> and <TrackProperty> which appear always black. As a workaround for 1.11 i`ll deactivate stylesheets for tooltip in these skins globally, they are now in QT standard yellow.

Tags: skin

Related branches

Revision history for this message
jus (jus) wrote :
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Is this still an issue?

Revision history for this message
jus (jus) wrote :

Unfortunately all the text in labels is black again like in the original bug description. Tested with current lp:mixxx/1.11.
I worked around it for 1.10.1 but cant't say when this slipped in again. Maybe related to changes in https://bazaar.launchpad.net/~mixxxdevelopers/mixxx/release-1.11.x/revision/3522

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Argh, yes that commit caused it.

Changed in mixxx:
milestone: none → 1.11.0
assignee: nobody → RJ Ryan (rryan)
importance: Undecided → Low
jus (jus)
Changed in mixxx:
status: New → Confirmed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Fixed the widget setup for WNumber/WLabel derivatives (WTrackProperty derives from WLabel). It turns out this was caused by a change in the ordering of setPalette and setStyle that I had caused in lp:mixxx/1.11 r3522. If you setPalette() after setStyle() then it will be ignored. I had to change the widget setup in LegacySkinParser so that WWidget::setup() is called before the composed widget goes through the standard (size/tooltip/style) setup.

Changed in mixxx:
status: Confirmed → Fix Committed
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Maybe we can finally get rid of Outline (and color schemes) in 1.12?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Why that ... after we put that much effort into iron out all issues.
We have currently no alternative like outline for netbooks.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6560

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.