Buttons with focus should have an orange outline

Bug #1020978 reported by Christopher Kyle Horton
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Salience
Fix Released
Medium
Aditya V

Bug Description

Similar to Ambiance, Salience should have buttons with focus from the keyboard have an orange (glowing) outline, such that when one presses Enter they know which button will be "pressed". This would look better and improve usability. See attached mockup.

Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :
Changed in salience:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Aditya V (kroq-gar78) wrote :

Thanks, I was going to report this bug ;)

Changed in salience:
milestone: none → 1.0
Aditya V (kroq-gar78)
Changed in salience:
status: Triaged → In Progress
assignee: nobody → kroq-gar78 (kroq-gar78)
Revision history for this message
Aditya V (kroq-gar78) wrote :

Got it to work in GTK 2 so far. Still looking into GTK 3...

Aditya V (kroq-gar78)
Changed in salience:
status: In Progress → Triaged
Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

Whatever changes need to be made to the GTK+3 version, they'll likely need to be made in gtk-3.0/button.css. Great work so far on the GTK+2, btw; I'd love to see the same look used in the GTK+3. :)

Revision history for this message
Aditya V (kroq-gar78) wrote :

Hmph. Looks like I just needed a clean slate, and I fixed it (mostly) in 1 try :/ I'll commit changes once GTK2 and GTK3 look mostly the same.

Changed in salience:
status: Triaged → In Progress
Revision history for this message
Aditya V (kroq-gar78) wrote :

OK, they look about the same now. What took me so long was actually a bug in A Widget Factory: it doesn't refresh the focus settings for the buttons. Closing and re-opening it should work.

Changed in salience:
status: In Progress → Fix Committed
milestone: 1.0 → 1.0-beta
Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

I can confirm this fixes the issue, but I notice the GTK+3 buttons' outline is solid orange while the outline for GTK+2 buttons has a gradient, making those look like they're glowing when they have focus. Can you tweak the button outlines slightly so the GTK+3 ones look like the GTK+2 ones? Thanks much!

Revision history for this message
Aditya V (kroq-gar78) wrote : Re: [Bug 1020978] Re: Buttons with focus should have an orange outline

I'll make GTK 3 look more like GTK 2, because I'm not sure if there are
many more settings for the focus in GTK 2.

Changed in salience:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.