Please add an icon for the slider on mouseover

Bug #1020410 reported by Aditya V
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Salience
Fix Released
Low
Aditya V

Bug Description

Currently, when one moves the mouse over a slider, nothing happens to the slider's image. In most themes, the slider gets slightly brightened to signal that the computer detects that the mouse is over the slider.

Though this could've been fixed with bug 1014208, but a workaround was applied instead, making the mouseover image the same as the default.

Related branches

Revision history for this message
Aditya V (kroq-gar78) wrote :
Changed in salience:
status: New → Triaged
Changed in salience:
assignee: nobody → Christopher Kyle Horton (christhehorton)
status: Triaged → In Progress
Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

The relevant asset is in the gtk-3.0/assets folder and is called scale-slider-hover.svg. It's now in use for GTK+3 (which includes the Unity Sound menu) but not for GTK+2 yet. Anyone know how to edit the gtkrc there so that uses it as well?

Changed in salience:
status: In Progress → Triaged
assignee: Christopher Kyle Horton (christhehorton) → nobody
Revision history for this message
cbowman57@live.com (cbowman57) wrote :

It's in the gtk-2.0/Range folder. Should just be able to overwrite the corresponding files in that folder.

Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

@cbowman57 Unless I'm mistaken, all that's necessary is copying the relevant image into the gtk-2.0/Range folder and adding an entry to the gtkrc specifically for hover on the range slider. When I looked in there, there were entries for vertical and horizontal sliders, but nothing for hover.

Aditya V (kroq-gar78)
Changed in salience:
milestone: 1.0 → none
Revision history for this message
cbowman57@live.com (cbowman57) wrote :

Ah, my mistake Chris. Been moving, it's been a crazy couple weeks but starting to wind down

At a glance it looks like an edit of the bg[PRELIGHT] values, near line 405 should do it. The copy I have here shows a value equal to the background color.

Revision history for this message
Aditya V (kroq-gar78) wrote :

Any example GTK 2 programs we can test this with?

Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

I use and personally recommend The Widget Factory (twf), installable from the Ubuntu Software Center here: https://apps.ubuntu.com/cat/applications/thewidgetfactory/ . Note that this is exclusively for testing GTK+2 themes; I haven't found a GTK+3 equivalent yet that can be easily installed.

Revision history for this message
cbowman57@live.com (cbowman57) wrote :

Your widget factory doesn't have an icon upper left, next to the reload symbol? Mine defaults to GTK2, but clicking that icon should open the GTK3 for you, displaying both in separate windows.

If the one from the ppa doesn't have it you may want to compile it from source. https://github.com/valr/awf

Aditya V (kroq-gar78)
Changed in salience:
assignee: nobody → kroq-gar78 (kroq-gar78)
status: Triaged → In Progress
Revision history for this message
Aditya V (kroq-gar78) wrote :

I found out how to do it, but I'm thinking of an efficient way to go about this. I should have the fix pushed by tomorrow night (~24hrs)

Revision history for this message
Aditya V (kroq-gar78) wrote :

Fixed, but some of the symlinks aren't standard (gtk-2.0 and gtk-3.0 are linking various files to each other; should only be one way). I'll fix that now.

This was fixed by adding an image entry to the "murrine-scale" style with the image as the hovered slider SVG. Also, I removed the "orientation" stuff from the style so that it's simpler, but it still works well AFAIK.

Changed in salience:
status: In Progress → Fix Committed
milestone: none → 1.0-beta
Revision history for this message
Christopher Kyle Horton (christhehorton) wrote :

I wonder how many times I'm going to have to say thanks. You're on a roll, keep up the good work and I appreciate the help! :D

Changed in salience:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.