Copying a collection is creating extra duplicates

[Stacey Walker]

User A has one collection and two pages:
* Page One (In Collection One)
* Page Two

Cloning of a single page works correctly, can rename and re-edit.

Cloning of the collection creates two extra collections instead of the one specified:
step 1: asks for new collection name (entered: Collection Two)
step 2: asks to manage pages (Page One is missing when it should show a copy, Page Two is correctly an option to select - User A chooses no new page)
Done + Save.

Now User A can see:
- 'Collection Two' with no pages
- Copy of 'Collection One' with 'Copy of Page One'

Should see only 'Collection Two' with Copy of Page One'. Images attached.

Issue seen on 1.6.0dev

[Kristina Hoeppner (kris-hoeppner)]

Hi Stacey,

Can you please pull the very latest code from today? I had a similar issue during the review of the group / institution / site collection changes, but that is fixed. I couldn't reproduce your issue on the latest code locally.

Cheers
Kristina

[Hugh Davenport (hugh-davenport)]

https://reviews.mahara.org/1395

[Hugh Davenport (hugh-davenport)]

May of been fixed by unrelated bug in commit 86d8cc21

[Hugh Davenport (hugh-davenport)]

See review, need to retest on master to see if still a bug

[Hugh Davenport (hugh-davenport)]

This was fixed accidentally by bug #886080

[Hugh Davenport (hugh-davenport)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----