Aged Partner Balance Report chooses FY for wrong company

[Chris Forbes]

Affected version: 6.1

The aged partner balance report does not select the correct company's fiscal year based on the selected CoA and date, and provides no widget to work around the problem.

When the report is run, this produces the following error:

    ValidationError: The fiscalyear, periods or chart of account chosen have to belong to the same company.

The attached patch fixes alters _get_fiscalyear to consider only FYs for the correct company.

[Saurang Suthar(OpenERP) (ssu-openerp)]

Hello Chris Forbes,

We have fixed the problem in lp:~openerp-dev/openobject-addons/trunk-bug-1018591-ssu branch, It will be merged soon in lp:openobject-addons.

Revision No: 7984
Revision ID: <email address hidden>

Thanks for your contribution.
Saurang Suthar

[Olivier Dony (Odoo) (odo-openerp)]

Chris, thank you for the patch, it was a good start. One small mistake: it was passing the company_id browse_record to the search domain instead of its ID, causing another error downstream (might not have been the case in 6.1, I did not double-check).
This was fixed and the issue should be solved after the corrected revision, in trunk[1].

Thanks a lot for reporting this bug and providing a fix!

PS: This fix was applied in trunk for the upcoming OpenERP 7.0, applying our bug management policy. See [2] for more details.

[1] trunk addons revision 8009 rev-id: <email address hidden>
[2] http://doc.openerp.com/v6.1/contribute/11_bug_tracker.html#bug-management-policy

[Olivier Dony (Odoo) (odo-openerp)]

Chris, I forgot to mention that your patch was initially merged at revision 8001, and credited to you:
   http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/revision/7983.1.1