fix clear shelf action with 25 or more holds

Bug #1017989 reported by Jason Etheridge
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.4
Fix Released
Medium
Unassigned

Bug Description

collab/phasefx/clear_shelf @ working/Evergreen.git
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/clear_shelf

commit 26cb4d7c255d43d9d55f34729f1530f50563eed3
Author: Jason Etheridge <email address hidden>
Date: Tue Jun 26 11:39:48 2012 -0400

    fix clear hold shelf with 25 or more holds

    When there are 25 or more shelf expired holds to be processed, the API call
    returns an array of objects instead of an object, which the staff client wasn't
    prepared to accommodate. This fixes that.

    Signed-off-by: Jason Etheridge <email address hidden>

Tags: pullrequest
Revision history for this message
Thomas Berezansky (tsbere) wrote :

Not realizing this branch existed I came up with a solution of my own.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/clear_shelf

Not sure which is the better one. Mine assumes that the only response that will ever have a cache key is the last one.

Revision history for this message
Mike Rylander (mrylander) wrote :

FWIW, while not having an example of the data structure in front of me, I feel a bit better about looking for a cache key than assuming the position of one.

Changed in evergreen:
status: New → Confirmed
Ben Shum (bshum)
Changed in evergreen:
milestone: none → 2.4.0-rc
Ben Shum (bshum)
Changed in evergreen:
milestone: 2.4.0-rc → none
Revision history for this message
Jason Etheridge (phasefx) wrote :

Hey guys, let's pick one of these patches and run with it. For what it's worth, I've been using the one I wrote with customers and it works fine.

Changed in evergreen:
milestone: none → 2.5.0-m2
Revision history for this message
Mike Rylander (mrylander) wrote :

I've picked Jason's, since that's currently used by multiple production sites. Merged to master and 2.4

Changed in evergreen:
status: Confirmed → Fix Committed
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.