set_mapping to mapping= argument in Silva extensions

[Martijn Faassen]

Make sure that any Silva extension that uses set_mapping uses the mapping
argument to the message id instead. Also modify the import to get the new style
MessageID class if necessary.

[Andy Altepeter (aaltepet)]

I recall needing to do something with this for perhaps SilvaNews. But what I don't recall is whether the code errors out or silently doesn't work as expected. If it errors out, I suppose this issue could be marked resolved. Otherwise, the legacy method could perhaps be marked as deprecated?

I've tested all of my products, and all of the Silva products (core, SilvaNews, Groups, etc). I believe any required changes to infrae-svn housed products that I found have been made.

[Andy Altepeter (aaltepet)]

Well, SilvaNewsNetwork 2.0.1 is still using set_mapping. Will this cause problems? I don't really know how to test this...

[Andy Altepeter (aaltepet)]

created a bug in snn to get this changed for SNN 2.0.1.
SilvaDocument/transform/base still uses set_mapping

[Eric Casteleijn (thisfred)]

Hmm, I'll fix SilvaDocument. It *will* cause problems, but probably only when the relevant scripts are called, not on startup. It needs to be fixed in SilvaNews 2.0.x as well.

[Eric Casteleijn (thisfred)]

set_mapping removed from SilvaDocument in trunk and 2.0 branch