New event is all day despite it being off

[Niels Avonds]

When creating a new event, the 'all day' switch is off by default, but when clicking the 'create' button, the event is created as an all day event.

[Niels Avonds (niels-avonds)]

Weird bugs this one. After some analysis:
- The start and end times are still set when calling the add event method in the sourcemanager
- Once the callback (event_added or something) is called, they are no longer present

This leads me to think we're doing something wrong when setting the times...

[Niels Avonds (niels-avonds)]

All events are set back to "all day" upon closing, so we're not setting the times correctly

[Corentin Noël (tintou)]

After investigating, I think that It's because we use icalendar...

I think that to fix that will require a lot of work because that means that we will have to remove our customs vapi and use thoose from libevolution...

Why I am saying that, It's because of this :

An ecalcomponent in Maya :
BEGIN:VEVENT
UID:20120625T181357Z-18352-1000-1-0@PC-Bureau
DTSTAMP:20120625T181357Z
DTSTART;VALUE=DATE:20120625
DTEND;VALUE=DATE:20120625
SUMMARY:test
CREATED:20120625T194830Z
LAST-MODIFIED:20120625T194941Z
END:VEVENT

An ecalcomponent in evolution :
BEGIN:VEVENT
UID:20120625T181357Z-18352-1000-1-0@PC-Bureau
DTSTAMP:20120625T181357Z
DTSTART;TZID=/freeassociation.sourceforge.net/Tzfile/Europe/Paris: 20120625T090000
DTEND;TZID=/freeassociation.sourceforge.net/Tzfile/Europe/Paris: 20120625T100000
SUMMARY:test
CREATED:20120625T181404Z
LAST-MODIFIED:20120625T191438Z
END:VEVENT

You can see the difference, they are both event named test, set for the 26/06/2012 from 9:00 to 10:00
You can also see that there is no time set on Maya, and no TimeZone...

So let's remove all theese custom vapi and have a solid base to build other function on !
Really that you Niels for that work !

[Niels Avonds (niels-avonds)]

Found the fix, turns out it's because we create the icaltimes from dates, and thus the "is_date" is set to 1. Setting it to 0 fixes it. Needs a little more work probably to work well with evolution, gonna test that now.