SNN: newsviewers do not appear in the inline viewer's parameters form select list

Bug #101616 reported by Kit Blake
20
Affects Status Importance Assigned to Milestone
SilvaNewsNetwork
Fix Released
Low
Andy Altepeter

Bug Description

The inv in SNN has a context problem. No newsviewers appear in the select list
in the Kupu toolbox.

Revision history for this message
Marc Petitmermet (petitmermet) wrote :

(already reported a few days ago;-) the acquisition of the viewers in the external source seems
weird for me. it acquires the viewers in the same folder as the code source. but this is not what an
author expects. the inline viewer should acquire all viewers which are in the same directory as the
silva document where it is inserted and all levels below. as it is setup now, authors might need
multiple silva news inline viewer code sources in different folders (but authors don't have access to
the zmi). this is against the philosophy of the new code sources: have one code source, change
the parameters.

Revision history for this message
Guido Wesdorp (guido-infrae) wrote :

Want to have this fixed right after an upcoming release, preferrably before news
gets prepared for the Silva 1.5 release (which I think now will be SNN 2.1).

Revision history for this message
Guido Wesdorp (guido-infrae) wrote :

Played around with this a bit, but it's really quite involved, so unfortunately
not going to fix it rightaway...

Revision history for this message
Kit Blake (kitblake) wrote :

Deferring this one, as the js has its own little virtual environment and isn't
conscious of anything in content space. Moving to 2.2.

Revision history for this message
Marc Petitmermet (petitmermet) wrote :

if the inline viewer would still be a pure code source i would elegantly solve
this problem by using the ReferenceLookupWindowField instead of a
programmatically populated ListField. wouldn't this simplify the code quite a bit?

Revision history for this message
Kit Blake (kitblake) wrote :

I'd love to use the ReferenceLookupWindowField, but unfortunately Guido ported
everything to js, and there's no js version of the ReferenceLookupWindowField.
Those tool boxes are done with js dom manipulation. But maybe that's the answer,
we might be able to lookup the viewers just like an image.

That's a little less friendly than presenting a pre-gathered list, but it also
may solve the problem of only having things in the list which can be acquired.
Thus you'd be able to refer to any viewer anywhere on the site.

Revision history for this message
Andy Altepeter (aaltepet) wrote :

This is fixed in my SNN branch, and will be rolled out in (hopefully) the next SNN release.

Changed in silva:
assignee: nobody → aaltepet
status: Incomplete → In Progress
Revision history for this message
Andy Altepeter (aaltepet) wrote :

This is fixed for 2.5.1. The INV now pulls all news, agenda viewers and rss aggregators from the context of the Document the NV will be included in, up to the VirtualHost root, or silva root.

Revision history for this message
Andy Altepeter (aaltepet) wrote :

Marc, SNN 2.6 will have an INV that is customizable through the ZMI. You'll be able to adjust the parameters form there, to change the behavior of the nv to be a lookup window. Since the INV is now working as intended, I don't know how important it is to change it so a referencelookupwindow is used instead? If you would like me to look into using a lookup window for the 2.6 milestone, please create a bug report for it.

Changed in silva-news-network:
status: In Progress → Fix Committed
Changed in silva-news-network:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.