SUDO_USER should be used also when calling with 'vcs commit'

[gizero]

In the past a patch was submitted to have the unprivileged user calling 'sudo etckeeper' being reported as the commit author instead of root. This involved using SUDO_USER instead of USER when calling the undelying VCS command. This appear to be implemented only for 'etckeeper commit'. My workflow more frequently involves calling 'etckeeper vcs add/commit' to separate logically different changes and for documentation purpose. I can try to propose a patch for this but hints are welcome to focus on the right place to implement such a change. Reporting here because I use etckeeper (0.52) with Ubuntu server (11.04) but looking at upstream code, no related changes result in the repo.

[Marc Cluet (lynxman)]

Hi gizero,

Thanks for submitting this bug, I've been trying to reproduce the bug but it works as expected on a clean natty 11.04 install. I would suggest to check the bzr /or your vcs of your choice) settings for the user/users that are not behaving properly.

=================

------------------------------------------------------------
revno: 2
committer: Marc Cluet <email address hidden>
branch nick: natty /etc repository
timestamp: Thu 2012-06-21 05:42:23 -0700
message:
  test
------------------------------------------------------------
revno: 1
committer: ubuntu <email address hidden>
branch nick: natty /etc repository
timestamp: Thu 2012-06-21 05:41:11 -0700
message:
  Initial commit
=============

Marking as invalid

[gizero (gizero-gmail)]

Hi Marc,

After checking my vcs backend configuration (I use git here), I found a misconfiguration of user settings. Now, I have a normalized behaviour of both workflows. Thank you for the valuable suggestion!