Check availability is wrong

[Carlos Liebana]

In v6.1:

If we have one delivery order with some stock available in any line, but not enough to satisfy it at all, the "Check availability" button should split those lines and create new ones with the quantity available. Above all, if the "Delivery Method" selected is "Partial delivery".

Let's see it with one example:

- Product A: we have 5 units
- We make a sale order, including 10 units of Product A (warning message displayed)
- In the delivery order, check availability should split the 10 units init line in 2: one "Ready to proccess" with the 5 units available and other "Waiting for availability" with the 5 units left.

[Amit Parik (amit-parik)]

Hello Carlos.

We can consider this as a "Good feature/Improvement" rather then a bug.

That's why I am setting this as a "Wishlist", we will consider this as a feature roadmaps.

Thanks for reporting!

[Naresh(OpenERP) (nch-openerp)]

As this is a feature request rather then a bug I am removing the OPW team as responsible .

Thanks,
Naresh Soni

[Carlos Liebana (carlos-liebana)]

This is not a "wishlist" or "new feature". Partial delivery is not working as it should.

[Nhomar - Vauxoo (nhomar)]

One Question My friends:

This is NOT a bug, I am agreed with the solution, shouldn't it be better improve the project

https://code.launchpad.net/~stock-logistic-core-editors/stock-logistic-flows/7.0

IMHO Overwrite this method and test with an extra module in an stable version is better.

just FYI we solved this with OpenERP as it is, and automate in other parts of the flow.

regards.

[Carlos Liebana (carlos-liebana)]

I don't agree, for me it's not improvement but bug. We should consider by default partial availability, I don't see any case that we don't.

[Nhomar - Vauxoo (nhomar)]

Hi Carlos.

I understand your point before, and I am agreed it is really cool split by default, but in business terms:

1.- Split is one option, when the Virtual Stock "Can be" sent splited (it means you say this explicitly on SO)
2.- Split is NOT an option, If you send always by internal policies "All or Nothing" (again you say this in SO)
3.- Split is an option, "If Wharehouse user have the 'ability'" to decide this, frequently this windows is used by a warehouse user.
4.- Split is NOT an option, if sent PArtially is MORE expensive than sent Toghether, (it depends of the kind of products)

With this four reasons (We have more user cases) I think the improvement is GOOD very GOOD but IMHO it can not be the default one, but again, this is my opinion.

IOH.

Your patch is not triggering the workflow correctly, I think the workflos must be triggered.

But again, I am sorry in be disagree (generally we are) but here i mantain My PoV this should be a feature in an extra module.

Regards.

[Ana Juaristi Olalde (ajuaristio)]

I think both you are "partially" right.

This is if you set on SO that you need sending when ALL products are available, then it works right. There is no bug.

On setting SO that you need sending when any product is available, then the line should be availabe if there is any product available and this is right BUT... when you are going to proccess line, system should show only quantity available to be sent, not SO's quantity and wizard should show only available lines and that's the bug, because user doesn't know quantity really available for products.

If only available quantity was shown on wizard, then everything will be right since the split line is made by default when procesing partial delivery.

My 2 cents.

Ana

[Nhomar - Vauxoo (nhomar)]

Excellent Ana, thanks for you feedback.

Yes, i think you in other world are saying my message.

It is a feature, and it can be solved in so different ways and your way is not right is not bad, is __one__ solution and in some cases it is good.

I hope it helps.

Regards

[Nhomar - Vauxoo (nhomar)]

Errata:

When I said, in other world
I try to say, in other words

[Carlos Liebana (carlos-liebana)]

Thanks for the feedback, guys. My comments:

@Nhomar

"1.- Split is one option, when the Virtual Stock "Can be" sent splited (it means you say this explicitly on SO)
2.- Split is NOT an option, If you send always by internal policies "All or Nothing" (again you say this in SO)"

You're right... or not. Actually we always split, but we respect the workflow and we can only process when all the quantities are available.

I agree with not splitting when SO is defined to be processed when all the products and quantities are available, although in some cases it could be useful to know the amount left en each line to proccess the shipping order.

We're going to change this.

"3.- Split is an option, "If Wharehouse user have the 'ability'" to decide this, frequently this windows is used by a warehouse user.
4.- Split is NOT an option, if sent PArtially is MORE expensive than sent Toghether, (it depends of the kind of products)"

Don't agree. As splitting only would happen when partial shippings are allowed in SO, we suppose that this means that all quantities should be allowed to be sent when available. This two scenarios make no sense for me in what we are trying to solve.

@Ana

"On setting SO that you need sending when any product is available, then the line should be availabe if there is any product available and this is right BUT... when you are going to proccess line, system should show only quantity available to be sent, not SO's quantity and wizard should show only available lines and that's the bug, because user doesn't know quantity really available for products."

That's exactly what we are trying to solve and what we think is a bug: when partial shippings are allowed and a product have some quantity, checking availabilty leaves this line as there is no quantity available at all... and the workflow doesn't move forward, so no process button is shown (at least other lines have quantity to process, of course).

What you propose may be conceptually right (or at least a good approach), but would require to change all the workflow of shipping orders.

[Hugo Santos (Factorlibre) (hugosantosred)]

Hello!

I've made a change on revision http://bazaar.launchpad.net/~hugosantosred/ocb-addons/6.1-lp1015717/revision/6731 that checks the picking move type that is set (When All products are available or deliver each product when available) and split move lines only if picking policy is deliver each product when available.