cutting and pasting doesn't strip msoNormal from paragraphs

Bug #101512 reported by Andy Altepeter
8
Affects Status Importance Assigned to Milestone
Silva
Fix Released
Medium
Andy Altepeter

Bug Description

It appears that kupu (in commin/kupucontentfilters.js, around line 440) does have
a blacklist of mso classnames to filter out, but they are case-sensitive. We have
documents our users are pasting from that have a different cases than the defined
(e.g. msoNormal instead of MsoNormal as paragraph class attribute). Cutting
and pasting (and saving) in kupu works fine, but the paragraph widget renderer
(both edit and view) don't understand the class (expecting one of the standard
silva styles) and hence skips rendering that content.

This is in Silva1.3 (actually, guido-kupu-1_3-branch) and a recent checkout of
kupu trunk

So:
1) Kupu should use a case-insensitive blacklist test
AND/OR
2) the behavior of the paragraph widget should fallback to 'normal' on unknown
classes.

Tags: kupu silva-1.6
Revision history for this message
Clemens Robbenhaar (crobbenhaar) wrote :

the second one should be implemented in any case, i feel.
how does the xslt renderer handle this, by the way?

Revision history for this message
Guido Wesdorp (guido-infrae) wrote :

I think this should be fixed on the Silva side, indeed the class should become
'normal' if it's not a known Silva class name. I thought it already worked like
that, though, will do some testing to find out why it doesn't.

Revision history for this message
Eric Casteleijn (thisfred) wrote :

Sorry deferring this. Guido is way too busy to fix this before 1.4 is released.

Revision history for this message
Martijn Faassen (faassen) wrote :

Deferring this before the 1.5 beta.

Revision history for this message
Martijn Faassen (faassen) wrote :

Please review this, Guido.

Revision history for this message
Martijn Faassen (faassen) wrote :

Never got a review, so deferring.

Revision history for this message
Flynt (flyntle) wrote :

This problems happens with much too many people as well here at ETH. Telling
them not to use MS Office documents for copy/paste produces loud laughter in the
case of the very nice users and other, more pronounced, comments by the others.

Changed in silva:
assignee: nobody → aaltepet
Revision history for this message
Andy Altepeter (aaltepet) wrote :

This bug was fixed awhile ago. While there still may be problems cutting and pasting from ms office into kupu, the particular one reported here is fixed. Please report new specific pasting problems in new issues.

Changed in silva:
milestone: none → 1.6
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.