We've just migrated a few sites over to the Silva-all-1.2.1 tarball. The
tab_status.py in views/edit/VersionedContent appears to have changed since
1.1.1, and it seems to be broken. Here's the use case:
1) author visits 'publish' tab of silva document
2) author clicks 'request approval'
3) author is sent to the edit tab instead of redisplaying publish tab with 'approval
requested' method.
Cause:
tab_status.py contains a generic <form> tag on line 41. This form tag declares an
action of '.', which is the usual paradigm if you're use submit buttons with
name:method names to marshall to functions. However, in the
tab_status_macros/macros/request_approval macro a <form> tag is declared wich
specifies an action of tab_status_request (the other method, not using zope's
marshalling).
I checked in the cvs head, and this still appears to be unfixed.
I have fixed the button, but unaware of this nested form, by changing the action
of the (apparently inner) form to '.' and changing the name of the button to
'tab_status_
obviously isn't very neat.
I'll not resolve this issue, even though the most important part of the request
is fixed (the button works again) I think it would be good to fix any mess in
tab_status considering nested forms at some point (perhaps before the 1.3 final,
perhaps after it).