columns missing from Class::DBI table definitions

[Galen Charlton]

Several columns are missing from various OpenILS::Application::Storage::CDBI::* classes, leading to noise like this in the stderr logs:

****
** last_update_time() isn't there. Please create me somewhere (like in actor::user)!
** Error at OpenILS::Application::Storage::CDBI (/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/CDBI.pm), line 181
** Call Stack (5 deep):
** OpenILS::Application::Storage::Publisher::action (/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm), line 976
** Error::subs (/usr/share/perl5/Error.pm), line 416
** Error::subs (/usr/share/perl5/Error.pm), line 408
** OpenILS::Application::Storage::Publisher::action (/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm), line 1004
** OpenSRF::Application (/usr/local/share/perl/5.10.1/OpenSRF/Application.pm), line 564
** Object type was actor::user
****

Current list of known columns:

  29331 ** current_shelf_lib() isn't there. Please create me somewhere (like in action::hold_request)!
3397898 ** last_update_time() isn't there. Please create me somewhere (like in actor::user)!
  29331 ** sms_carrier() isn't there. Please create me somewhere (like in action::hold_request)!
  29331 ** sms_notify() isn't there. Please create me somewhere (like in action::hold_request)!

Evergreen: master and 2.2

[Galen Charlton (gmc)]

Patch available in the working/Evergreen repository at the tip of branch user/gmcharlt/lp1014664_add_columns_to_cdbi. Request backport to rel_2_2.

[Michael Peters (mrpeters)]

Any chance of a backport to rel_2_1? This is killing our utility server. Will total up at least 2GB of logs full of this junk per week. Crippling, if no one is available to remove the log and restart services every few days. I think we can all agree that having to restart services daily due to these logs is a little outrageous.

If it can't be backported, could someone please propose a secondary solution for those of us not permitted to upgrade at this time?

[Michael Peters (mrpeters)]

Ignore me. As senator pointed out, last_update_time doesn't appear in 2.1. We backported that feature because we had a pressing need for it.

[Lebbeous Fogle-Weekley (lebbeous)]

Signed-off and pushed to master and rel_2_2. As for rel_2_1, Michael Peters and I determined that a vanilla installation of a 2.1 release shouldn't have this bug, so we're calling this complete.