Silva SQL Sources: table caption

Bug #101447 reported by Marc Petitmermet
12
Affects Status Importance Assigned to Milestone
Silva
Fix Released
Medium
Unassigned

Bug Description

whatever setting i try i cannot get rid of the caption. even setting the default
to be unchecked in the parameters. my solution was to just delete the part with
the title in the layout page template. if i remember correctly this has
something to do with a bug in silva external sources and checkboxes. this seems
not to be fixed in silva-1.1.5 and silva-1.3beta3.

Revision history for this message
Guido Wesdorp (guido-infrae) wrote :

There seem to be two problems with this: first when you unset the checkbox, it
will appear in the re-rendered form checked. This most probably has to do with
the problem you mention, it's hard (if not impossible) to find out whether
something needs to be done when a checkbox' value is not in a request. However,
this seems to *not* be the reason for the caption to appear, also because even
though the checkbox is checked in the form the value written to the code
source's div (and in the end to the Silva XML) *is* correct, that is False when
the checkbox was unchecked before sending the form.

After digging around I found that the way the layout.pt template determined
whether to show caption or not is wrong. I fixed that not on the
SilvaExternalSources trunk, please test.

Revision history for this message
Marc Petitmermet (petitmermet) wrote :

now, the caption can be toggled on and off. although the checkbox in kubu does
not represent the custom setting. it is alway checked upon a update source; it
does not read the current setting.

can you please tell me where the column titles have gone? looking at the source,
it seems that you have forgotten to add the show_column_heading parameter. i did
this manually and then everything works as expected (except the checkboxes not
correctly showing the current state).

Changed in silva:
assignee: guido-infrae → aaltepet
Revision history for this message
Andy Altepeter (aaltepet) wrote :

Marc, Is this still a problem? It's been awhile. It appears that as of ES 0.10.3, a fix was made to get the show_column_headers working. Also, as of Silva 1.5 (I think), checkboxes in external sources were working.

Just trying to figure out if these are still issues for you or not.

Changed in silva:
assignee: aaltepet → petitmermet
Revision history for this message
Marc Petitmermet (petitmermet) wrote :

well, the checkboxes work as expected. but the show_column_heading parameter is still missing and turning caption on/ off does not seem to work anymore. i'm using Silva-1.6 with SilvaExternalSources-1.2.

Changed in silva:
assignee: petitmermet → aaltepet
Revision history for this message
Andy Altepeter (aaltepet) wrote :

This is fixed in the SilvaExternalSources trunk. A checkout of this will only work against the current Silva trunk (which will become Silva 2.1). The two files I changed were: layout/parameters.xml and layout/table.zpt.

Specifically, I added a "show_column_headings" checkboxfield, and in the zpt, checkbox field values are integers, 0 for "not checked" and 1 for "checked". The zpt was updated to reflect this.b

Changed in silva:
milestone: none → 2.1
status: In Progress → Fix Committed
Changed in silva:
assignee: aaltepet → nobody
Changed in silva:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.