Authorities not validating in 2.2 + patch

[Steve Callender]

Tested in 2.2 rc1. Authorities were not validating.

First there was an error with the actual validation portion. When clicking the validate button, Evergreen would stop and error on the first checked field causing the validation button to append the tag to the end of it in a never ending cycle.

For example, clicking Validate enough times would cause the button to look like, "Validate - 100 - 100 - 100 - 100 - 100 - 100".

This problem was due to the way the authority.normalize_heading was processing marc records.

I've included a patch that I worked on with Mike Rylander to fix this problem.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=4910db432470c1922da516c029c37d523dac8451

Secondary issue, Evergreen is not building the test code correctly when validating marc.

CALL: open-ils.cstore open-ils.cstore.json_query.atomic {"from":"are","select":{"are":["id"]},"where":{"marc":{"startwith":{"transform":"authority.simple_normalize_heading","value":["authority.simple_normalize_heading","<record xmlns=\"http://www.loc.gov/MARC21/slim\"><leader>00000czm a2200205Ka 4500</leader><datafield tag=\"100\" ind1=\" \" ind2=\" \"><subfield code=\"a\">d</subfield></datafield></record>"]}},"control_set":"1","deleted":"f"}}

In the above, there should be a subfield a + the field contents, and a subfield d + the field contents. It's being translated to subfield a with a contents of d instead, so whatever code is building this is off. This part still needs to be investigated and fixed.

Steve

[Mike Rylander (mrylander)]

I've signed off and squashed this at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/authority_normalize_heading_fix

[Mike Rylander (mrylander)]

This has been heavily tested in production at several sites. It's time to merge.